Skip to content

fix(emails): account for false order value in email hook #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chickenn00dle merged 1 commit into from
Dec 2, 2024
Merged

fix(emails): account for false order value in email hook #3590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions includes/reader-revenue/woocommerce/class-woocommerce-connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,14 +267,14 @@ public static function force_disable_order_attribution( $should_allow ) {
* @return bool
*/
public static function send_customizable_receipt_email( $enable, $order, $class ) {
// If there are no donation products in the order, do not override the default WC receipt email.
$has_donation_product = \Newspack\Donations::get_order_donation_product_id( $order->get_id() ) !== false;
if ( ! $has_donation_product ) {
// If we don't have a valid order, or the customizable email isn't enabled, bail.
if ( empty( $order ) || ! is_a( $order, 'WC_Order' ) || ! Emails::can_send_email( Reader_Revenue_Emails::EMAIL_TYPES['RECEIPT'] ) ) {
return $enable;
}

// If we don't have a valid order, or the customizable email isn't enabled, bail.
if ( ! is_a( $order, 'WC_Order' ) || ! Emails::can_send_email( Reader_Revenue_Emails::EMAIL_TYPES['RECEIPT'] ) ) {
// If there are no donation products in the order, do not override the default WC receipt email.
$has_donation_product = \Newspack\Donations::get_order_donation_product_id( $order->get_id() ) !== false;
if ( ! $has_donation_product ) {
return $enable;
}

Expand Down