fix(ia): deprecate webhooks global endpoint

[miguelpeixe]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

1205919985867982-as-1208628153846581/f

Implements changes from #3492 to the IA project.

How to test the changes in this Pull Request:

1. Navigate to "Newspack -> Settings" and at the Connections tab, scroll to the Webhooks section
2. Click to create a new endpoint and confirm the "Global" option is no longer available
3. Attempt to save without a URL or selecting any actions
4. Confirm the modal scrolls to the top and you see an error message
5. Fill a random string (invalid URL) and attempt to save
6. Confirm you get an error due to invalid format
7. Put a valid URL and select some actions
8. Confirm you can save the endpoint
9. Refresh the page and confirm the endpoint persist

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[miguelpeixe]

This was printing two :, removed the one from the localized string

[miguelpeixe]

Not sure why this would ever be undefined so I removed it

[jaredrethman]

@miguelpeixe code looks good, I made one non-blocking comment about validating URLs below. Feel free to keep or change as you think!

[jaredrethman]

This can be modernized to use URL interface for example:

export function validateUrl( url: string ): string | false {
	if ( ! url ) {
		return __( 'URL is required.', 'newspack-plugin' );
	}
	try {
		const urlObject = new URL( url );
		// Ensure the protocol is either http or https
		if ( ! [ 'http:', 'https:' ].includes( urlObject.protocol ) ) {
			return __( 'URL must use HTTP or HTTPS protocol.', 'newspack-plugin' );
		}
		return false;
	} catch ( error ) {
		return __( 'Invalid URL format.', 'newspack-plugin' );
	}
}

There is also a function inside @wordpress/url called isUrl which also validates urls using the above pattern.

[miguelpeixe]

Good call! Updated in 9eb2589. While at it, I also restricted to HTTPS, which is enforced in the backend.

[jaredrethman]

Code+changes look great, approved!