feat(site-kit): add logging when site kit disconnects #3472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenn00dle
force-pushed
the
feat/site-kit-add-logging-on-disconnect
branch
2 times, most recently
from
fc03623 to
b948ebf
Compare
chickenn00dle
force-pushed
the
feat/site-kit-add-logging-on-disconnect
branch
from
b948ebf to
856f034
Compare
chickenn00dle
force-pushed
the
feat/site-kit-add-logging-on-disconnect
branch
from
3e50ac4 to
023544e
Compare
chickenn00dle
force-pushed
the
feat/site-kit-add-logging-on-disconnect
branch
from
fc6877b to
81e290e
Compare
chickenn00dle
added
the
[Status] Needs Review
leogermani
approved these changes
Oct 18, 2024
Contributor
leogermani
left a comment
leogermani
left a comment
There was a problem hiding this comment.
Beautiful.
I did a small change to bum the log level for the cron check so we can get more proactive alerts
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Nov 6, 2024
# [5.7.0-alpha.1](v5.6.0...v5.7.0-alpha.1) (2024-11-06) ### Bug Fixes * avoid duplicate info notices in email editors ([#3512](#3512)) ([d38fc1a](d38fc1a)) * **co-authors-plus:** CLI for migrating from CAP GA ([9a81584](9a81584)) * command to fix active subs w/ missing next_payment dates ([#3484](#3484)) ([2e05fd4](2e05fd4)) * php fatal and warning ([#3502](#3502)) ([e089172](e089172)) * **site-kit:** update logger cron to hourly interval ([#3485](#3485)) ([e3823e7](e3823e7)) * **webhooks:** deprecate global endpoint ([#3492](#3492)) ([63e8ab2](63e8ab2)) * **wp-6.7:** update radio control styles ([#3518](#3518)) ([831756e](831756e)) ### Features * add user name to woocommerce data events ([#3473](#3473)) ([5312d30](5312d30)) * automatically disable guest authors ([#3345](#3345)) ([d0db6ba](d0db6ba)) * **connections:** jetpack sso ([#3486](#3486)) ([123408e](123408e)) * display list remote name on newsletter wizard ([#3478](#3478)) ([cd0b859](cd0b859)) * **site-kit:** add logging when site kit disconnects ([#3472](#3472)) ([62bf98c](62bf98c))
Contributor
|
🎉 This PR is included in version 5.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 11, 2024
# [5.7.0](v5.6.1...v5.7.0) (2024-11-11) ### Bug Fixes * avoid duplicate info notices in email editors ([#3512](#3512)) ([d38fc1a](d38fc1a)) * **co-authors-plus:** CLI for migrating from CAP GA ([9a81584](9a81584)) * command to fix active subs w/ missing next_payment dates ([#3484](#3484)) ([2e05fd4](2e05fd4)) * php fatal and warning ([#3502](#3502)) ([e089172](e089172)) * **site-kit:** update logger cron to hourly interval ([#3485](#3485)) ([e3823e7](e3823e7)) * **webhooks:** deprecate global endpoint ([#3492](#3492)) ([63e8ab2](63e8ab2)) * **wp-6.7:** update radio control styles ([#3518](#3518)) ([831756e](831756e)) ### Features * add user name to woocommerce data events ([#3473](#3473)) ([5312d30](5312d30)) * automatically disable guest authors ([#3345](#3345)) ([d0db6ba](d0db6ba)) * **connections:** jetpack sso ([#3486](#3486)) ([123408e](123408e)) * display list remote name on newsletter wizard ([#3478](#3478)) ([cd0b859](cd0b859)) * **site-kit:** add logging when site kit disconnects ([#3472](#3472)) ([62bf98c](62bf98c))
Contributor
|
🎉 This PR is included in version 5.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1206274567818686/1207849727795693
This PR adds newspack manager logging whenever we detect a site kit disconnection via:
delete_option_{option}hook for thehas_connected_adminoption.update_user_metadatahook for when thedisconnected_reasonuser meta is updated.For the first two cases, a backtrace is included in the log. For the final one, we simply log a message.
How to test the changes in this Pull Request:
newspack_googlesitekit_disconnection_loggercron event is present./tmp/like/tmp/2024-XX-XX-newspack_googlesitekit_disconnectNo active Google Site Kit connections foundGoogle Site Kit has been disconnected for all adminsGoogle Site Kit has been disconnected with reason REASONOther information: