Skip to content

Conversation

@adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

  1. Changes the ESP field names Membership Plan (added in feat(esp-sync): sync membership data regardless of subscription #3353) to Membership Plans, to handle multiple plan names
  2. Fixes a bug reported here: feat(esp-sync): sync membership data regardless of subscription #3353 (comment)

Note that 1. is not a breaking change since #3353 is not released. This PR will have to be merged to alpha ("alpha-hotfix").

How to test the changes in this Pull Request:

  1. In the Engagement wizard, "Email Service Provider (ESP) Advanced Settings" section, ensure "Sync contacts to ESP" is toggled on
  2. Create a new membership, with a new contact – observe it's synced to the ESP, with Membership Plans field present
  3. Add a plan to the membership, observe both plans' names are synced in the field

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Sep 13, 2024
@adekbadek adekbadek requested a review from a team as a code owner September 13, 2024 07:09
@adekbadek
Copy link
Member Author

It looks like these fields are planned for removal in #3411, so the fixes here won't apply.

@adekbadek adekbadek closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The issue or pull request needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants