Skip to content

Conversation

@adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Newspack discourages the use of Co-Authors Plus' Guest Authors feature and offers a way to migrate them to WP Users (#3068). This PR adds an optional (behind NEWSPACK_DISABLE_GUEST_AUTHORS feature flag) blocking of the "Guest Authors" menu item.

How to test the changes in this Pull Request:

  1. Install Co-Authors Plus and visit the Users -> Guest Authors link, observe that Guest Authors can be added
  2. Set NEWSPACK_DISABLE_GUEST_AUTHORS environment variable to true
  3. Refresh the page, observe that the Users -> Guest Authors link leads to this message and Guest Authors can't be added here:
image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 9, 2024
@adekbadek adekbadek requested a review from a team as a code owner July 9, 2024 10:38
@leogermani
Copy link
Contributor

You can disable guest authors by simply doing add_filter( 'coauthors_guest_authors_enabled', '__return_false' )

@adekbadek
Copy link
Member Author

I know! The intention here is to say "use this instead of the thing you were used to", not just hide a feature and leave the user wondering why it disappeared.

@adekbadek
Copy link
Member Author

Note: this PR will possibly be replaced by #3238

@adekbadek adekbadek removed the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 12, 2024
@adekbadek adekbadek marked this pull request as draft July 12, 2024 06:51
@adekbadek
Copy link
Member Author

Superseded by #3277

@adekbadek adekbadek closed this Aug 29, 2024
@adekbadek adekbadek deleted the feat/cap-block-guest-authors branch August 29, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants