Skip to content

fix: add frequency tab options for donations, even when tiers are disabled #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laurelfulford merged 2 commits into from
Feb 15, 2024
Merged

fix: add frequency tab options for donations, even when tiers are disabled #2930

laurelfulford merged 2 commits into from
Feb 15, 2024

Conversation

@laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Feb 14, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This change comes out of feedback for the alpha release for this change: #2866

If you don't install Name Your Price, or you turn off the Tiered view of the donate block's site-wide settings under Newspack > Reader Revenue > Donations, you can no longer change the frequency amount site-wide. Instead, it's sticks to whatever the last saved selection was when the Tiered view was visible.

This is not a new issue, but is more noticeable with us supporting not using Name Your Price: with that plugin, you can still switch back to the Tiered view and change the default frequencies. Without it, you can't.

I'm not entirely sold on the UI decisions I made here, but this PR adds the frequency toggles to the untiered view. I'm definitely open to other suggestions about fixing this both for the short and long term!

See pamTN9-8My-p2-#comment-10416

How to test the changes in this Pull Request:

  1. Apply this PR and run npm run build.
  2. Navigate to Newspack > Reader Revenue > Donations.
  3. Toggle the view to 'Untiered', and confirm that you now see frequency toggles above each field:

image

  1. Try toggling different options on and off. Confirm that the associated field is hidden when the frequency is 'off'.
  2. Try toggling between the Tiered and Untiered view, and make changes to the frequency settings on each. Confirmed they're carried over, even when the page is saved and refreshed.
  3. With the Untiered view selected and one or more frequencies is disabled, add a Donate block to a page, and confirm the initial appearance matches your selection (for example, if you've disabled the One-Time donation option, it should not appear in the block by default):

image

  1. Turn back on the Tiered view under Reader Revenue > Donations, and change the selection again and save it.
  2. Try disabling the Name Your Price plugin, and confirm your active frequencies remain the same.
  3. Change the frequencies again and save.
  4. Try adding another Donation block to a page, and confirm the visible tabs match your frequency choices.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 14, 2024
@laurelfulford laurelfulford requested a review from a team as a code owner February 14, 2024 18:26
chickenn00dle
chickenn00dle approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 15, 2024
@laurelfulford laurelfulford merged commit cb7eb7b into trunk Feb 15, 2024
@laurelfulford laurelfulford deleted the fix/disable-tabs-without-tiers-donate branch February 15, 2024 01:12
matticbot pushed a commit that referenced this pull request Feb 15, 2024
@semantic-release-bot
chore(release): 3.1.0-alpha.4 [skip ci]
e958e5d 
# [3.1.0-alpha.4](v3.1.0-alpha.3...v3.1.0-alpha.4) (2024-02-15)

### Bug Fixes

* add frequency tab options for donations, even when tiers are disabled ([#2930](#2930)) ([cb7eb7b](cb7eb7b))
@matticbot
Copy link
Contributor

matticbot commented Feb 15, 2024

🎉 This PR is included in version 3.1.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

matticbot commented Feb 15, 2024

🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 20, 2024
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
ffc44d2 
# [3.1.0](v3.0.5...v3.1.0) (2024-02-20)

### Bug Fixes

* add frequency tab options for donations, even when tiers are disabled ([#2930](#2930)) ([cb7eb7b](cb7eb7b))
* **categories:** fix pager urls ([#2913](#2913)) ([bb7e534](bb7e534))
* **categories:** fix pager urls ([#2913](#2913)) ([c851bb6](c851bb6))
* **engagement-wizard:** handle error when retrieving subscription lists ([e85c108](e85c108))
* **ras:** only sync spend total and last payment amounts for completed orders ([#2886](#2886)) ([68aaf39](68aaf39))
* redirect to origin from magic link ([9f41947](9f41947))
* typescript errors ([dc27973](dc27973))
* TypeScript usage; add to CI ([#2884](#2884)) ([6f5e7a6](6f5e7a6))
* update newsletter scroll appearance in Sign Up modal ([#2897](#2897)) ([496723a](496723a))
* update path to wide template file ([#2918](#2918)) ([fdd6b69](fdd6b69))

### Features

* **ci:** add epic/* release workflow and rename `master` to `trunk` ([#2895](#2895)) ([ea02075](ea02075)), closes [#2897](#2897) [#2886](#2886)
* **reader-revenue:** make NYP and Stripe Gateway optional ([#2866](#2866)) ([fcfa88c](fcfa88c))
* remove new tab default on image credits ([#2880](#2880)) ([3c996b1](3c996b1))
* **wc:** override cart, checkout, and my-account page templates ([#2893](#2893)) ([68b1836](68b1836))
@matticbot
Copy link
Contributor

matticbot commented Feb 20, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chickenn00dle chickenn00dle chickenn00dle approved these changes

Assignees

No one assigned

Labels

released on @alpha released on @epic/ras-acc released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laurelfulford @matticbot @chickenn00dle