fix(data-events): no longer use ActionScheduler for dispatches #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Nov 30, 2023
# [2.12.0-alpha.1](v2.11.3...v2.12.0-alpha.1) (2023-11-30) ### Bug Fixes * **checkout:** move stripe's cover fee placement ([#2767](#2767)) ([5f8b539](5f8b539)) * **data-events:** no longer use ActionScheduler for dispatches ([#2755](#2755)) ([975ab96](975ab96)) * **metering:** restrict comments on gated content ([#2751](#2751)) ([1bfc6f0](1bfc6f0)) * **recaptcha:** refresh token on checkout error ([#2769](#2769)) ([f22e8bd](f22e8bd)) ### Features * add filters for assets enqueueing ([#2768](#2768)) ([fcad059](fcad059)) * **authentication:** rate limit magic links and OTP generation ([#2765](#2765)) ([1252515](1252515)) * **campaigns:** mark duplicate segments ([cb5b527](cb5b527)) * **data-events:** track content gate interactions ([#2740](#2740)) ([298fd7c](298fd7c)) * **donations:** disable coupons for donation checkout ([#2770](#2770)) ([6051429](6051429))
Contributor
|
🎉 This PR is included in version 2.12.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 11, 2023
# [2.12.0](v2.11.6...v2.12.0) (2023-12-11) ### Bug Fixes * **checkout:** move stripe's cover fee placement ([#2767](#2767)) ([5f8b539](5f8b539)) * **data-events:** no longer use ActionScheduler for dispatches ([#2755](#2755)) ([975ab96](975ab96)) * **metering:** restrict comments on gated content ([#2751](#2751)) ([1bfc6f0](1bfc6f0)) * **recaptcha:** refresh token on checkout error ([#2769](#2769)) ([f22e8bd](f22e8bd)) ### Features * add filters for assets enqueueing ([#2768](#2768)) ([fcad059](fcad059)) * **authentication:** rate limit magic links and OTP generation ([#2765](#2765)) ([1252515](1252515)) * **campaigns:** mark duplicate segments ([cb5b527](cb5b527)) * **data-events:** track content gate interactions ([#2740](#2740)) ([298fd7c](298fd7c)) * **donations:** disable coupons for donation checkout ([#2770](#2770)) ([6051429](6051429))
Contributor
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Removes the use of ActionScheduler for dispatching data events. It should use the fallback strategy in place for when AS is not available, which is to send an unblocking HTTP request.
The reason for this change is that the amount of data events we dispatch drastically increased, especially with Newspack Newsletters' tracking functionality. This can be too much for AS' queue to handle.
This change shouldn't impact the processing or reliability of data events, since this is already the strategy in place for sites without AS available (without WooCommerce installed).
Update: 30ff764 adds a check for a WC function on the GA4 connector so it doesn't fatal if WC is not installed.
How to test the changes in this Pull Request:
define( 'NEWSPACK_LOG_LEVEL', 2 );define( 'NEWSPACK_EXPERIMENTAL_WEBHOOKS', true );. You can use https://webhook.site/ to register a test endpointDispatching action "reader_logged_in".Other information: