Skip to content

Conversation

@adekbadek
Copy link
Member

@adekbadek adekbadek commented Aug 3, 2022

All Submissions:

Changes proposed in this Pull Request:

Legacy contacts handling for ActiveCampaign.

How to test the changes in this Pull Request:

  1. Switch Newsletters to feat/all-details-for-contact branch
  2. Setup a site with ActiveCampaign ESP & Reader Activation
  3. Create a contact in AC manually, one which is not on the site
  4. Register as this contact
  5. Observe the new contact metadata is added in AC – NP_Account, registration or signup data, signup page URL

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek self-assigned this Aug 3, 2022
Base automatically changed from fix/ga-events-server-side to master August 4, 2022 07:17
@adekbadek adekbadek force-pushed the fix/legacy-ac-contacts branch from 21f1923 to e7b05db Compare August 4, 2022 07:30
@adekbadek adekbadek marked this pull request as ready for review August 4, 2022 07:42
@adekbadek adekbadek requested a review from a team as a code owner August 4, 2022 07:42
@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 4, 2022
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 4, 2022
@adekbadek adekbadek merged commit 34dd9a2 into master Aug 4, 2022
@adekbadek adekbadek deleted the fix/legacy-ac-contacts branch August 4, 2022 14:57
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.88.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.89.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.89.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reader Activation released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants