Skip to content

fix(registration-block): don't escape html for sign in labels #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelpeixe merged 3 commits into from
Aug 2, 2022
Merged

fix(registration-block): don't escape html for sign in labels #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcc12c0
fix(registration-block): don't escape html for sign in labels
miguelpeixe Aug 2, 2022
811a4af
fix: replace escaping strategy to wp kses
miguelpeixe Aug 2, 2022
cc9665d
fix: escape newsletter label
miguelpeixe Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions assets/blocks/reader-registration/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function render_block( $attrs, $content ) {
<?php if ( $registered ) : ?>
<div class="newspack-registration__success">
<div class="newspack-registration__icon"></div>
<?php echo $success_markup; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
<?php echo \wp_kses_post( $success_markup ); ?>
</div>
<?php else : ?>
<form>
Expand Down Expand Up @@ -170,19 +170,21 @@ function render_block( $attrs, $content ) {

<div class="newspack-registration__help-text">
<p>
<?php echo $attrs['privacyLabel']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
<?php echo \wp_kses_post( $attrs['privacyLabel'] ); ?>
</p>
<p>
<?php echo \esc_html( $attrs['haveAccountLabel'] ); ?>
<a href="<?php echo \esc_url( $sign_in_url ); ?>" data-newspack-reader-account-link><?php echo \esc_html( $attrs['signInLabel'] ); ?></a>
<?php echo \wp_kses_post( $attrs['haveAccountLabel'] ); ?>
<a href="<?php echo \esc_url( $sign_in_url ); ?>" data-newspack-reader-account-link>
<?php echo \wp_kses_post( $attrs['signInLabel'] ); ?>
</a>
</p>
</div>
</div>
</div>
</form>
<div class="newspack-registration__success newspack-registration--hidden">
<div class="newspack-registration__icon"></div>
<?php echo $success_markup; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
<?php echo \wp_kses_post( $success_markup ); ?>
</div>
<?php endif; ?>
</div>
Expand Down
2 changes: 1 addition & 1 deletion includes/class-reader-activation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ public static function render_subscription_lists_inputs( $lists = [], $checked =
<span class="<?php echo \esc_attr( $class( 'title' ) ); ?>">
<?php
if ( 1 === count( $lists ) ) {
echo $config['single_label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
echo \wp_kses_post( $config['single_label'] );
} else {
echo \esc_html( $list['title'] );
}
Expand Down