Skip to content

feat: handle contact update w/out lists selection #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adekbadek merged 3 commits into from
Jul 29, 2022
Merged

feat: handle contact update w/out lists selection #1816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c9463b
feat: handle contact update w/out lists selection
adekbadek Jul 29, 2022
c2fd699
doc: typo
adekbadek Jul 29, 2022
f8ca0b4
refactor: remove unneeded condition
adekbadek Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions includes/plugins/class-newspack-newsletters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ public static function newspack_newsletters_update_contact_lists( $provider, $em
/**
* Modify metadata for newsletter contact creation.
*
* @param string $provider The provider name.
* @param array $contact {
* Contact information.
* @param string $provider The provider name.
* @param array $contact {
* Contact information.
*
* @type string $email Contact email address.
* @type string $name Contact name. Optional.
* @type string[] $metadata Contact additional metadata. Optional.
* }
* @param string[] $selected_list_ids Array of list IDs to subscribe the contact to.
* @param string[]|false $selected_list_ids Array of list IDs the contact will be subscribed to, or false.
*/
public static function newspack_newsletters_contact_data( $provider, $contact, $selected_list_ids ) {
switch ( $provider ) {
Expand Down Expand Up @@ -89,25 +89,28 @@ public static function newspack_newsletters_contact_data( $provider, $contact, $
// Move along.
}

// Translate list IDs to list names and store as metadata.
try {
if ( method_exists( '\Newspack_Newsletters_Subscription', 'get_lists' ) ) {
$lists = \Newspack_Newsletters_Subscription::get_lists();
if ( ! is_wp_error( $lists ) ) {
$lists_names = [];
foreach ( $selected_list_ids as $selected_list_id ) {
foreach ( $lists as $list ) {
if ( $list['id'] === $selected_list_id ) {
$lists_names[] = $list['name'];
// Translate list IDs to list names and store as metadata, if lists are supplied.
// The list ids can be an empty array, which means the contact has been unsubscribed from all lists.
if ( false !== $selected_list_ids ) {
try {
if ( method_exists( '\Newspack_Newsletters_Subscription', 'get_lists' ) ) {
$lists = \Newspack_Newsletters_Subscription::get_lists();
if ( ! is_wp_error( $lists ) ) {
$lists_names = [];
foreach ( $selected_list_ids as $selected_list_id ) {
foreach ( $lists as $list ) {
if ( $list['id'] === $selected_list_id ) {
$lists_names[] = $list['name'];
}
}
}
// Note: this field will be overwritten every time it's updated.
$metadata['NP_Newsletter Selection'] = implode( ', ', $lists_names );
}
// Note: this field will be overwritten every time it's updated.
$metadata['NP_Newsletter Selection'] = implode( ', ', $lists_names );
}
} catch ( \Throwable $e ) { // phpcs:ignore Generic.CodeAnalysis.EmptyStatement.DetectedCatch
// Move along.
}
} catch ( \Throwable $e ) { // phpcs:ignore Generic.CodeAnalysis.EmptyStatement.DetectedCatch
// Move along.
}

$signup_page_url = isset( $contact['metadata'], $contact['metadata']['current_page_url'] ) ? $contact['metadata']['current_page_url'] : null;
Expand Down