fix(reader-revenue): initial order state with total of 0

[adekbadek]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Because the order was created as completed, an email was sent right away to the site admin, with a 0 as order total.

How to test the changes in this Pull Request:

1. Choose "Stripe" as the Reader Revenue platform and make sure your site is available publicly (so Stripe webhook can be called)
2. On master, make a donation using the Donate block
3. Observe an email is sent to site admin with no order details and 0 as total
4. Switch to this branch, observe the email sent has order details and correct amount

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

@adekbadek How do you ensure that the admin email is sent? I followed the testing instructions but never got an email.

[dkoo]

@adekbadek How do you ensure that the admin email is sent? I followed the testing instructions but never got an email.

[adekbadek]

@dkoo – can you verify if the webhook was executed and returned 200, in Stripe dashboard?

[dkoo]

While testing this, I found that there's a conflict with the Salesforce webhooks that are active when a Salesforce connection is established. That connection should probably only be active if the Reader Revenue platform is Newspack, so I'll submit a fix in a separate PR.

After fixing that I was able to confirm the fix in this PR:

[matticbot]

🎉 This PR is included in version 1.84.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 1.84.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀