fix: dynamic class property deprecated warnings #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
requested changes
Feb 13, 2024
Contributor
There was a problem hiding this comment.
It looks like the $action attribute above is not being used. I guess it was renamed in the code, but not here. It looks like we can safely rename that one instead of creating a new one
chickenn00dle
force-pushed
the
fix/deprecated-dynamic-properties
branch
from
0a72552 to
991f008
Compare
leogermani
approved these changes
Feb 13, 2024
matticbot
pushed a commit
that referenced
this pull request
Feb 15, 2024
# [1.2.0-alpha.2](v1.2.0-alpha.1...v1.2.0-alpha.2) (2024-02-15) ### Bug Fixes * assorted error handling fixes ([#52](#52)) ([234f883](234f883)) * dynamic class property deprecated warnings ([#47](#47)) ([693865c](693865c)) * prevent coauthors capability check infinite loop ([#46](#46)) ([9565cef](9565cef)) * set Yoast primary category ([#41](#41)) ([3457d19](3457d19)) ### Features * sync billing and shipping addresses ([#50](#50)) ([6a05580](6a05580)) * sync publish, trash post statuses ([#42](#42)) ([fd5d8b9](fd5d8b9))
Contributor
|
🎉 This PR is included in version 1.2.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 20, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-02-20) ### Bug Fixes * assorted error handling fixes ([#52](#52)) ([234f883](234f883)) * **data-listeners:** handle no user in wc data update ([4eeefc0](4eeefc0)) * dynamic class property deprecated warnings ([#47](#47)) ([693865c](693865c)) * prevent coauthors capability check infinite loop ([#46](#46)) ([9565cef](9565cef)) * race condition when creating a Node ([1946473](1946473)) * set Yoast primary category ([#41](#41)) ([3457d19](3457d19)) ### Features * **ci:** add epic/* release workflow and rename `master` to `trunk` ([#39](#39)) ([9cee51d](9cee51d)) * sync billing and shipping addresses ([#50](#50)) ([6a05580](6a05580)) * sync publish, trash post statuses ([#42](#42)) ([fd5d8b9](fd5d8b9))
Contributor
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just addresses some warnings flooding the logs:
Testing instructions
Code review should be fine, but feel free to checkout this branch and confirm these warning no longer appear whenever network related events are triggered.