feat(content-distribution): add CLI command for distribute post #159

naxoc · 2024-12-09T12:04:49Z

This adds a CLI command to distribute a post.

I added support for passing 'all' or a list of urls to the --sites param, but not site_ids. The original task was —sites(all|site_ids|site_urls). Is the site ids thing necessary? I feel like it might introduce more error than convenience. I'm happy to add it if we have a use case that makes sense.

I didn't add tests because it doesn't make much sense to test CLI commands that just calls code that has tests.

This one relies on #164 being merged for sync to work.

How to test

# Create a post on the hub:
wp post create --post_content="Oh, wow" --post_status=publish --post_title="I'll go places from $(wp option get blogname)"
# Grab the ID and call this:
wp newspack network distribute post <post-id> --sites=https://node1.test
# Check that the post shows up.

# Now do it again with one more site to test the adding of sites:
wp newspack network distribute post <post-id> --sites=https://node2.test

# Create another post and test with 'all'
wp newspack network distribute post <post-id> --sites=all

# Now find a page ID and run the below. It should throw an error
wp newspack network distribute post <page-id> --sites=https://google.com

* feat: content distribution class * feat: insert linked post * refactor: use site url instead of ID * chore: lint * feat: return errors on post insert * chore: lint * feat: support webhooks request priority * feat: unlink functionality and unit tests * chore: lint * feat: introduce 'linked_post_inserted' hook and listener * chore: lint * fix: listener hook name * fix: typo * chore: better docblocks * chore: remove redundant code * test: persist post hash * test: remove unnecessary assertion * refactor: distribute_post() to use handle_post_updated() method * refactor: post hash is now network post id * chore: update comment

…ts (#156)

…nfig (#165)

naxoc · 2024-12-12T15:44:32Z

OK, @miguelpeixe – I had to update the test a bit with some mockery, but I think this is ready for re-review.

Note that the set_config() now returns the config – I use it to write a message to the CLI. Let me know if that makes no sense.

miguelpeixe

That's perfect! Thank you for all the revisions 🎉

One nitpicky thing below

miguelpeixe · 2024-12-12T17:34:24Z

includes/content-distribution/class-outgoing-post.php

+		// If there are urls not already in the config, add them. Note that we don't support
+		// removing urls from the config.
+		$config['site_urls'] = array_unique( array_merge( $config['site_urls'], $site_urls ) );


Can we unit test this new thing?

Yep! I added a test 👍

github-actions · 2024-12-12T19:58:22Z

Hey @naxoc, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

# [2.4.0-alpha.1](v2.3.4...v2.4.0-alpha.1) (2025-01-10) ### Bug Fixes * **content-distribution:** post insertion hook and additional meta for incoming post event ([#173](#173)) ([48df13c](48df13c)) * load text domain on init hook ([#171](#171)) ([01fb89c](01fb89c)) ### Features * content distribution - experimental ([#168](#168)) ([dc837d8](dc837d8)) * **content-distribution:** add CLI command for distribute post ([#159](#159)) ([7a43b86](7a43b86)), closes [#155](#155) [#156](#156) [#157](#157) [#160](#160) [#165](#165) * **content-distribution:** canonical url ([#177](#177)) ([5ca60ce](5ca60ce)) * **content-distribution:** capability and admin page ([#176](#176)) ([5285285](5285285)) * **content-distribution:** control distribution meta and prevent multiple dispatches ([#170](#170)) ([e76a2dc](e76a2dc)) * **content-distribution:** editor plugin for distribution ([#167](#167)) ([e10aef4](e10aef4)) * **content-distribution:** handle status changes ([#166](#166)) ([4af5da1](4af5da1)) * **content-distribution:** log incoming post errors ([#182](#182)) ([74c9119](74c9119)) * **content-distribution:** posts column ([#178](#178)) ([8e07640](8e07640)) * **content-distribution:** reserved taxonomies ([#174](#174)) ([a2c54d2](a2c54d2)) * **content-distribution:** sync comment and ping statuses ([#179](#179)) ([90c5425](90c5425)) * **content-distribution:** sync post meta ([#163](#163)) ([353a3d8](353a3d8)) * **event-log:** collapse data ([#180](#180)) ([956219d](956219d)) * limit purchase of a network membership ([#169](#169)) ([deb2683](deb2683))

matticbot · 2025-01-10T22:30:25Z

🎉 This PR is included in version 2.4.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [2.4.0](v2.3.4...v2.4.0) (2025-01-20) ### Bug Fixes * **content-distribution:** post insertion hook and additional meta for incoming post event ([#173](#173)) ([48df13c](48df13c)) * load text domain on init hook ([#171](#171)) ([01fb89c](01fb89c)) ### Features * content distribution - experimental ([#168](#168)) ([dc837d8](dc837d8)) * **content-distribution:** add CLI command for distribute post ([#159](#159)) ([7a43b86](7a43b86)), closes [#155](#155) [#156](#156) [#157](#157) [#160](#160) [#165](#165) * **content-distribution:** canonical url ([#177](#177)) ([5ca60ce](5ca60ce)) * **content-distribution:** capability and admin page ([#176](#176)) ([5285285](5285285)) * **content-distribution:** control distribution meta and prevent multiple dispatches ([#170](#170)) ([e76a2dc](e76a2dc)) * **content-distribution:** editor plugin for distribution ([#167](#167)) ([e10aef4](e10aef4)) * **content-distribution:** handle status changes ([#166](#166)) ([4af5da1](4af5da1)) * **content-distribution:** log incoming post errors ([#182](#182)) ([74c9119](74c9119)) * **content-distribution:** posts column ([#178](#178)) ([8e07640](8e07640)) * **content-distribution:** reserved taxonomies ([#174](#174)) ([a2c54d2](a2c54d2)) * **content-distribution:** sync comment and ping statuses ([#179](#179)) ([90c5425](90c5425)) * **content-distribution:** sync post meta ([#163](#163)) ([353a3d8](353a3d8)) * **event-log:** collapse data ([#180](#180)) ([956219d](956219d)) * limit purchase of a network membership ([#169](#169)) ([deb2683](deb2683))

matticbot · 2025-01-20T18:04:31Z

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

miguelpeixe and others added 23 commits November 28, 2024 12:24

feat: content distribution class

9997fd5

feat: insert linked post

7a5153d

refactor: use site url instead of ID

4230692

chore: lint

0561d77

feat: return errors on post insert

e1aee3f

chore: lint

6d5e931

feat: support webhooks request priority

34dcbf3

feat: unlink functionality and unit tests

5e47bbe

chore: lint

ca10658

feat: introduce 'linked_post_inserted' hook and listener

136ed6a

chore: lint

7738de3

fix: listener hook name

6095800

fix: typo

699228a

chore: better docblocks

0bf9c37

chore: remove redundant code

20d5dc0

test: persist post hash

fb501d4

test: remove unnecessary assertion

548a571

refactor: distribute_post() to use handle_post_updated() method

b0c0a0d

refactor: post hash is now network post id

2d3f9ca

chore: update comment

78c7f01

chore: Add CLI command for distribute

491bf9f

Merge branch 'epic/content-distribution' into feat/distribute-post-cli

a397989

naxoc requested a review from a team as a code owner December 9, 2024 12:04

naxoc changed the base branch from trunk to epic/content-distribution December 9, 2024 12:05

miguelpeixe and others added 4 commits December 9, 2024 10:31

feat(content-distribution): prevent older content updating linked pos…

cd4339d

…ts (#156)

feat(content-distribution): handle post thumbnail (#157)

f2de08c

Add network util class

db14c66

Almost done except for a few todos

49936b4

naxoc self-assigned this Dec 10, 2024

miguelpeixe and others added 6 commits December 11, 2024 12:01

fix(content-distribution): debug post update and remove deprecated co…

47bd6b6

…nfig (#165)

Merge branch 'epic/content-distribution' into feat/distribute-post-cli

9722f56

fix: Don't return payload on all posts

aa12aea

fix: post handling

745754f

chore: move try-catch

c64f15b

chore: Move check for networked urls

b0c5f5d

Base automatically changed from epic/content-distribution to trunk December 12, 2024 13:00

naxoc added 5 commits December 12, 2024 14:18

Move more

6e33778

Merge branch 'trunk' into feat/distribute-post-cli

8427f77

Move things again

7146907

chore: Add a mock networked node

587e668

chore: add one more node to the mock nodes

aeb190b

naxoc requested a review from miguelpeixe December 12, 2024 15:44

miguelpeixe requested changes Dec 12, 2024

View reviewed changes

Add a test

17c4359

miguelpeixe approved these changes Dec 12, 2024

View reviewed changes

Merge branch 'trunk' into feat/distribute-post-cli

d0b0743

naxoc changed the title ~~feat: add CLI command for distribute post~~ feat(content-distribution): add CLI command for distribute post Dec 12, 2024

naxoc merged commit 7a43b86 into trunk Dec 12, 2024

github-actions bot added the needs-changelog label Dec 12, 2024

leogermani removed the needs-changelog label Dec 13, 2024

matticbot added the released on @alpha label Jan 10, 2025

matticbot added the released label Jan 20, 2025

adekbadek deleted the feat/distribute-post-cli branch August 28, 2025 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(content-distribution): add CLI command for distribute post #159

feat(content-distribution): add CLI command for distribute post #159

Uh oh!

naxoc commented Dec 9, 2024 •

edited

Loading

Uh oh!

naxoc commented Dec 12, 2024

Uh oh!

miguelpeixe left a comment

Uh oh!

miguelpeixe Dec 12, 2024

Uh oh!

naxoc Dec 12, 2024

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

matticbot commented Jan 10, 2025

Uh oh!

matticbot commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(content-distribution): add CLI command for distribute post #159

feat(content-distribution): add CLI command for distribute post #159

Uh oh!

Conversation

naxoc commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test

Uh oh!

naxoc commented Dec 12, 2024

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

miguelpeixe Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

naxoc Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

matticbot commented Jan 10, 2025

Uh oh!

matticbot commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

naxoc commented Dec 9, 2024 •

edited

Loading