fix: load text domain on init hook #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
approved these changes
Dec 16, 2024
|
Hey @dkoo, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Dec 16, 2024
## [2.0.3-alpha.1](v2.0.2...v2.0.3-alpha.1) (2024-12-16) ### Bug Fixes * load text domain on init hook ([#66](#66)) ([f7d8261](f7d8261))
Contributor
|
🎉 This PR is included in version 2.0.3-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 16, 2024
## [2.0.3](v2.0.2...v2.0.3) (2024-12-16) ### Bug Fixes * load text domain on init hook ([#66](#66)) ([f7d8261](f7d8261))
Contributor
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a warning about calling
load_plugin_textdomaintoo early. Also fixes the text domain itself for the plugin.Testing
There are currently no translation files for this plugin, so just test that you don't see a PHP warning
PHP Notice: Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>newspack-plugin</code> domain was triggered too early. If you are seeing it on this branch, make sure yournewspack-pluginrepo has the changes from this Plugin branch.