fix(wp-6.7): update radio control styles #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
chickenn00dle
force-pushed
the
fix/wp-6.7-radio-control-styles
branch
from
9ca7d86 to
387bf48
Compare
chickenn00dle
force-pushed
the
fix/wp-6.7-radio-control-styles
branch
from
387bf48 to
5aeeb6a
Compare
dkoo
approved these changes
Nov 5, 2024
Contributor
dkoo
left a comment
dkoo
left a comment
There was a problem hiding this comment.
Looks good in both 6.6 and 6.7! As noted in the other PR, this will require a new NPM package version of Newspack Components.
Contributor
|
🎉 This PR is included in version 2.0.2-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Contributor
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 1208604228632024-as-1208605400743645/f
Goes with the following main plugin PR: Automattic/newspack-plugin#3518
This PR updates the styles for our radio control component to avoid conflicts with WP 6.7 radio control updates.
Before:
After:
Testing instructions:
Be sure to also checkout Automattic/newspack-plugin#3518 before testing.
Point the
newspack-componentspackage to your local instance ofnewspack-components(src/componentswithin thenewspack-plugindirectory)npm install path/to/newspack/componentsnewspack-componentsdirectorynpm run compile && npm run prepublishOnly)newspack-multibranded-sitedirectory and reinstall/build (npm install && npm run build)Test radio control inputs (do this for both WP 6.6 and WP 6.7