Skip to content

Conversation

@adekbadek
Copy link
Member

@adekbadek adekbadek commented Jul 30, 2024

All Submissions:

Changes proposed in this Pull Request:

A hotfix.

Amends #1728 to handle not-logged-in users, assuming their user ID from the email provided at checkout.

How to test the changes in this Pull Request:

  1. Create or edit a subscription product – in the Advanced settings section, add limiting:
image
  1. Purchase the subscription, then log out and purchase it again with the same email address
  2. Observe the second subscription cannot be bought

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Amends # 1728 to handle not-logged-in users, assuming their user ID from
the email provided at checkout.
@adekbadek adekbadek requested a review from a team as a code owner July 30, 2024 08:54
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionally works well, but the error message isn't very helpful and also includes a link to the Shop page, which doesn't play well with the modal checkout iframe. Let's see if we can make this a bit more user-friendly

Screenshot 2024-08-05 at 2 19 21 PM

@dkoo
Copy link
Contributor

dkoo commented Aug 5, 2024

6d40ff7 adds some filtering to make the error messaging a little clearer and more contextual when limiting purchase in the modal checkout:

Screenshot 2024-08-05 at 3 34 57 PM

Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and work well!

@adekbadek
Copy link
Member Author

Assuming @dkoo 's contributions amount to an approval :)

@adekbadek adekbadek merged commit d85a818 into release Aug 12, 2024
@adekbadek adekbadek deleted the hotfix/subs-limiting branch August 12, 2024 08:52
matticbot pushed a commit that referenced this pull request Aug 12, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Bug Fixes

* **wc-subs-limiting:** handle not-logged-in user ([#1816](#1816)) ([d85a818](d85a818))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 12, 2024
# [4.0.0-alpha.2](v4.0.0-alpha.1...v4.0.0-alpha.2) (2024-08-12)

### Bug Fixes

* **wc-subs-limiting:** handle not-logged-in user ([#1816](#1816)) ([d85a818](d85a818))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants