Skip to content

Conversation

@adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Adjusts the author URL in the Homepage Posts block, so the same one is used for the author image and name links. The code removed only doubles what's already done in the prepare_authors method.

How to test the changes in this Pull Request:

  1. Insert a Homepage Posts block
  2. On the frontend, observe both author links – the one in the avatar and the author's name – are the same

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! 🙌 Tested with a regular user, guest author, and mapped guest author.

@dkoo dkoo merged commit 2f80876 into trunk Apr 25, 2024
@dkoo dkoo deleted the fix/hpb-author-url branch April 25, 2024 15:53
matticbot pushed a commit that referenced this pull request Apr 25, 2024
# [3.1.0-alpha.1](v3.0.10...v3.1.0-alpha.1) (2024-04-25)

### Bug Fixes

* **homepage-articles:** author URL ([#1710](#1710)) ([2f80876](2f80876))
* **iframe-block:** prevent fatal error on blocks without attributes ([#1708](#1708)) ([4077ee8](4077ee8))
* make sure font scale 5 previews in editor ([#1706](#1706)) ([43bda7c](43bda7c))

### Features

* homepage articles update loading animation ([#1709](#1709)) ([d2ca12e](d2ca12e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 15, 2024
# [3.1.0](v3.0.11...v3.1.0) (2024-05-15)

### Bug Fixes

* **homepage-articles:** author URL ([#1710](#1710)) ([2f80876](2f80876))
* **iframe-block:** prevent fatal error on blocks without attributes ([#1708](#1708)) ([4077ee8](4077ee8))
* make sure font scale 5 previews in editor ([#1706](#1706)) ([43bda7c](43bda7c))

### Features

* homepage articles update loading animation ([#1709](#1709)) ([d2ca12e](d2ca12e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-epic-ras-acc.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants