chore: deprecate circleci #403
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates the existing CircleCI-based CI/CD pipeline and replaces it with GitHub Actions workflows using Automattic/newspack-scripts reusable workflows, along with updating the newspack-scripts toolchain reference in package-lock.json.
Changes:
- Remove the CircleCI configuration and associated jobs (build, lint, i18n, release, post-release, PHP).
- Add GitHub Actions workflows for build/test, PHP linting, i18n, release/post-release, and distributable builds based on
Automattic/newspack-scriptsreusable workflows. - Update the
newspack-scriptsentry inpackage-lock.jsonto resolve from a specific Git commit in theAutomattic/newspack-scriptsrepository instead of the npm registry tarball.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Points newspack-scripts to a specific commit in the Automattic/newspack-scripts repo, aligning the local toolchain with the reusable GitHub workflows but introducing a git-based resolution. |
| .github/workflows/release.yml | Introduces a Release workflow that builds, runs semantic release via reusable workflow, and runs a post-release job for the release branch. |
| .github/workflows/php.yml | Adds a PHP workflow that runs reusable PHP linting on PRs and pushes to main release-related branches. |
| .github/workflows/i18n.yml | Adds an Internationalization workflow that runs reusable i18n tasks on pushes to trunk. |
| .github/workflows/build-distributable.yml | Adds a distributable build workflow using the reusable build-distributable workflow, currently triggered only on PRs. |
| .github/workflows/build-and-test.yml | Adds a general Build and Test workflow using reusable build and JS/SCSS lint workflows on PRs and pushes to main release-related branches. |
| .circleci/config.yml | Removes the legacy CircleCI configuration and its workflows in favor of GitHub Actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| on: | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-distributable: | ||
| uses: Automattic/newspack-scripts/.github/workflows/reusable-build-distributable.yml@trunk | ||
| with: | ||
| archive-name: newspack-block-theme |
There was a problem hiding this comment.
In the CircleCI config, the build-distributable job was tied to the release workflow (requiring newspack/release) and therefore produced archives on release, alpha, hotfix/*, and epic/* branches, but this GitHub Actions workflow only runs on pull_request events. If you still rely on CI-generated distributable archives for those release branches, you may want to add corresponding push triggers for release, alpha, hotfix/**, and epic/** here to preserve the previous behavior.
Same as Automattic/newspack-plugin#4413