feat: add underline to navigation styles #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
approved these changes
Jan 31, 2024
Contributor
laurelfulford
left a comment
laurelfulford
left a comment
There was a problem hiding this comment.
Works as described!
It's a more opinionated style for a navigation, so I have a feeling we'll be asked to remove this one some sites 😬 But it's the kind of thing we can test in the wild vs. going off assumptions!
Contributor
Author
True. I wish we could control the underline via the block settings. At the moment it adds it to the |
matticbot
pushed a commit
that referenced
this pull request
Feb 8, 2024
# [1.6.0-alpha.1](v1.5.0...v1.6.0-alpha.1) (2024-02-08) ### Features * add underline to navigation styles ([#112](#112)) ([d52e92d](d52e92d)) * **ci:** add epic/* release workflow and rename `master` to `trunk` ([#119](#119)) ([b27b7d7](b27b7d7)) * rename colour variables ([#117](#117)) ([d263ccd](d263ccd))
|
🎉 This PR is included in version 1.6.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Links in the navigation block are now using an underline, transparent by default, then coloured on hover. This allowed for a smooth transition when hovering.
I also increased the thickness of the line.
How to test the changes in this Pull Request:
Other information: