Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow browser build to be published (fix #8427) #8435

Merged
merged 1 commit into from
Dec 20, 2019
Merged

allow browser build to be published (fix #8427) #8435

merged 1 commit into from
Dec 20, 2019

Conversation

captaincaius
Copy link
Contributor

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.

If you're making a change to documentation, do not modify a .html file directly. Instead find the corresponding .pug file or test case in the test/docs directory.

Summary

Fixes missing dist folder in published package

Examples

@captaincaius captaincaius changed the base branch from master to 5.8 December 17, 2019 20:31
@captaincaius captaincaius changed the base branch from 5.8 to master December 17, 2019 20:33
@captaincaius
Copy link
Contributor Author

I realized this is against master - should I redo (or cherrypick) starting from 5.8 instead? The README says all PRs should be to master, but it's looking like you may have evolved your strategy since it was written.

vkarpov15
vkarpov15 approved these changes Dec 20, 2019
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@vkarpov15
Copy link
Collaborator

No worries about making this PR against master and no need to cherrypick, all the commits that are in 5.8 are in master. The README is correct IMO, most PR's should be against master because they usually aren't significant enough to go in a minor or major release.

@vkarpov15 vkarpov15 added this to the 5.8.2 milestone Dec 20, 2019
@vkarpov15 vkarpov15 merged commit e5b6fd9 into Automattic:master Dec 20, 2019
vkarpov15 added a commit that referenced this pull request Jul 27, 2020
@vkarpov15
docs(browser): remove "Building with Webpack" section since we have a…
8cbaf0a 
… pre-built bundle

Re: #8435
Re: #9273
@vkarpov15 vkarpov15 mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@captaincaius @vkarpov15