Skip to content

Conversation

simllll
Copy link
Contributor

@simllll simllll commented Aug 15, 2018

upgrades underyling mongodb driver:

upgrades underyling mongodb driver, fixes mongos reconnect issues and a lot of other features/bug fixes: https://github.com/mongodb/node-mongodb-native/blob/master/HISTORY.md
@simllll simllll changed the title Chore: mongodb to 3.1.3, mongodb-core to 3.1.2 Upgrade mongodb to 3.1.3 and mongodb-core to 3.1.2 Aug 15, 2018
@simllll simllll changed the title Upgrade mongodb to 3.1.3 and mongodb-core to 3.1.2 Upgrade driver: mongodb to 3.1.3 and mongodb-core to 3.1.2 Aug 15, 2018
@simllll simllll changed the title Upgrade driver: mongodb to 3.1.3 and mongodb-core to 3.1.2 Upgrade driver: mongodb to 3.1.3 and mongodb-core to 3.1.2, fixes #6692 & #6670 Aug 15, 2018
@simllll
Copy link
Contributor Author

simllll commented Aug 15, 2018

Not sure what's happening with the travis build,

1) transactions
       "before all" hook:
     Uncaught TypeError: Cannot read property 'close' of undefined
      at topology.connect (node_modules/mongodb/lib/operations/mongo_client_ops.js:412:16)
      at ReplSet.<anonymous> (node_modules/mongodb/lib/topologies/replset.js:364:11)
      at node_modules/mongodb-core/lib/topologies/replset.js:634:14
      at Server.<anonymous> (node_modules/mongodb-core/lib/topologies/replset.js:357:9)
      at node_modules/mongodb-core/lib/topologies/server.js:508:16
      at node_modules/mongodb-core/lib/connection/pool.js:531:18
      at process._tickCallback (internal/process/next_tick.js:61:11)

seems like an underlying library issue, I've created a new PR there mongodb/node-mongodb-native#1812 to fix this

@vkarpov15
Copy link
Collaborator

vkarpov15 commented Aug 15, 2018

Thanks for your patience and digging into this issue, but unfortunately I can't merge this until mongodb/node-mongodb-native#1812 is merged.

@vkarpov15
Copy link
Collaborator

d907dc2 is enough to make tests pass locally for me, so I'll merge this 👍

@vkarpov15 vkarpov15 added this to the 5.2.9 milestone Aug 16, 2018
@vkarpov15 vkarpov15 merged commit 25196b2 into Automattic:master Aug 16, 2018
Fonger added a commit to Fonger/mongoose that referenced this pull request Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants