fix: fix validation for deeply nested maps of subdocuments #15469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15447
The issue was that mongoose was double validating nested maps of subdocuments, once as the correct path, but then trying to validate
.$*
which represents the map schema rather than the actual value of a path.The bug was in the
_getPathsToValidate
function inlib/document.js
. We were incorrectly treating map schema paths (paths ending with.$*
) as actual document paths for validation. These$*
paths represent the schema for Maps but are not actual document paths that should be validated.This PR ignores the
.$*
"path" when getting paths to validate.