Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: correct schema type inference when using nested typeKey like type: { type: String } #14956

Merged
merged 1 commit into from
Oct 14, 2024
Merged

types: correct schema type inference when using nested typeKey like type: { type: String } #14956

merged 1 commit into from
Oct 14, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14950

Summary

#14950 points out that it is tricky to handle GeoJSON with TypeScript schema definitions because inferschematype doesn't handle type: { type: String } correctly.

Examples

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Oct 12, 2024
@vkarpov15 vkarpov15 added this to the 8.7.2 milestone Oct 14, 2024
@vkarpov15 vkarpov15 merged commit 0752c5d into master Oct 14, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14950 branch October 15, 2024 09:12
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Nov 8, 2024
Merged
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
This was referenced Nov 9, 2024
Merged
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
@AndrewTroll AndrewTroll mentioned this pull request Nov 11, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
This was referenced Nov 11, 2024
Merged
Merged
@desujoy desujoy mentioned this pull request Nov 11, 2024
Merged
@axqqt axqqt mentioned this pull request Nov 11, 2024
Open
@sachinthapa572 sachinthapa572 mentioned this pull request Nov 11, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@Yogananda1504 Yogananda1504 mentioned this pull request Nov 12, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 12, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 12, 2024
Open
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 12, 2024
Merged
@ST10029788 ST10029788 mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 13, 2024
Merged
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.7.2
Development

Successfully merging this pull request may close these issues.

Using typeKey and required throws a TypeError: Invalid schema configuration
2 participants
@vkarpov15 @hasezoey