Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements for insertMany() #14724

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Performance improvements for insertMany() #14724

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
772f665
perf(document): avoid unnecessary set creation in $__reset() re: #14719
vkarpov15 Jul 3, 2024
72cb0b7
perf(document): skip parallel validate check when creating new docume…
vkarpov15 Jul 3, 2024
97a6ac4
Merge branch 'master' into vkarpov15/gh-14719
vkarpov15 Jul 8, 2024
69de006
perf: use fast path for cloning document with only primitive values r…
vkarpov15 Jul 8, 2024
517f27b
perf(document): only loop over doc once when shallow cloning re: #14719
vkarpov15 Jul 8, 2024
a860270
Merge branch 'master' into vkarpov15/gh-14719
vkarpov15 Jul 9, 2024
b698c28
perf(model): skip $toObject() for insertMany with only primitive values
vkarpov15 Jul 9, 2024
9dc2e8a
Merge branch 'master' into vkarpov15/gh-14719
vkarpov15 Jul 9, 2024
8223f91
refactor: rename to $__toObjectShallow() based on code review comments
vkarpov15 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions lib/document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3868,17 +3868,21 @@ Document.prototype.$toObject = function(options, json) {
if (hasOnlyPrimitiveValues) {
// Fast path: if we don't have any nested objects or arrays, we only need a
// shallow clone.
ret = this._doc
? options.minimize ? (minimize({ ...this._doc }) || {}) : { ...this._doc }
: {};
if (!options.minimize || options.flattenObjectIds) {
const keys = Object.keys(ret);
for (const key of keys) {
// If `minimize` is false, still need to remove undefined keys
if (!options.minimize && ret[key] === undefined) {
if (this._doc == null) {
ret = {};
vkarpov15 marked this conversation as resolved.
Show resolved Hide resolved
}
ret = {};
if (this._doc != null) {
for (const key of Object.keys(this._doc)) {
const value = this._doc[key];
if (value instanceof Date) {
ret[key] = new Date(value);
} else if (value === undefined) {
delete ret[key];
} else if (options.flattenObjectIds && isBsonType(ret[key], 'ObjectId')) {
ret[key] = ret[key].toJSON();
} else if (options.flattenObjectIds && isBsonType(value, 'ObjectId')) {
ret[key] = value.toJSON();
} else {
ret[key] = value;
}
}
}
Expand Down
Loading