Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the value of overwriteModels in options #14646

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

uditha-g
Copy link

@uditha-g uditha-g commented Jun 3, 2024

Summary

When we call the discriminator function of a model we can pass options with overwriteModels Boolean field.
But that field isn't considered in the logic.

Examples

model.discriminator(discriminatorName, schema, { overwriteModels: true });

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thank you 👍

@vkarpov15 vkarpov15 added this to the 8.4.2 milestone Jun 4, 2024
@vkarpov15 vkarpov15 merged commit c71ba5e into Automattic:master Jun 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants