Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(models+query): infer return type from schema for 1-level deep nested paths #14632

Merged
merged 1 commit into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 64 additions & 1 deletion test/types/models.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ import mongoose, {
Query,
UpdateWriteOpResult,
AggregateOptions,
StringSchemaDefinition
WithLevel1NestedPaths,
NestedPaths,
InferSchemaType
} from 'mongoose';
import { expectAssignable, expectError, expectType } from 'tsd';
import { AutoTypedSchemaType, autoTypedSchema } from './schema.test';
Expand Down Expand Up @@ -914,3 +916,64 @@ async function gh14440() {
}
]);
}

async function gh12064() {
const FooSchema = new Schema({
one: { type: String }
});

const MyRecordSchema = new Schema({
_id: { type: String },
foo: { type: FooSchema },
arr: [Number]
});

const MyRecord = model('MyRecord', MyRecordSchema);

expectType<(string | null)[]>(
await MyRecord.distinct('foo.one').exec()
);
expectType<(string | null)[]>(
await MyRecord.find().distinct('foo.one').exec()
);
expectType<unknown[]>(await MyRecord.distinct('foo.two').exec());
expectType<unknown[]>(await MyRecord.distinct('arr.0').exec());
}

function testWithLevel1NestedPaths() {
type Test1 = WithLevel1NestedPaths<{
topLevel: number,
nested1Level: {
l2: string
},
nested2Level: {
l2: { l3: boolean }
}
}>;

expectType<{
topLevel: number,
nested1Level: { l2: string },
'nested1Level.l2': string,
nested2Level: { l2: { l3: boolean } },
'nested2Level.l2': { l3: boolean }
}>({} as Test1);

const FooSchema = new Schema({
one: { type: String }
});

const schema = new Schema({
_id: { type: String },
foo: { type: FooSchema }
});

type InferredDocType = InferSchemaType<typeof schema>;

type Test2 = WithLevel1NestedPaths<InferredDocType>;
expectAssignable<{
_id: string | null | undefined,
foo?: { one?: string | null | undefined } | null | undefined,
'foo.one': string | null | undefined
}>({} as Test2);
}
6 changes: 5 additions & 1 deletion types/models.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,11 @@ declare module 'mongoose' {
field: DocKey,
filter?: FilterQuery<TRawDocType>
): QueryWithHelpers<
Array<DocKey extends keyof TRawDocType ? Unpacked<TRawDocType[DocKey]> : ResultType>,
Array<
DocKey extends keyof WithLevel1NestedPaths<TRawDocType>
? WithoutUndefined<Unpacked<WithLevel1NestedPaths<TRawDocType>[DocKey]>>
: ResultType
>,
THydratedDocumentType,
TQueryHelpers,
TRawDocType,
Expand Down
13 changes: 12 additions & 1 deletion types/query.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,18 @@ declare module 'mongoose' {
distinct<DocKey extends string, ResultType = unknown>(
field: DocKey,
filter?: FilterQuery<RawDocType>
): QueryWithHelpers<Array<DocKey extends keyof DocType ? Unpacked<DocType[DocKey]> : ResultType>, DocType, THelpers, RawDocType, 'distinct', TInstanceMethods>;
): QueryWithHelpers<
Array<
DocKey extends keyof WithLevel1NestedPaths<DocType>
? WithoutUndefined<Unpacked<WithLevel1NestedPaths<DocType>[DocKey]>>
: ResultType
>,
DocType,
THelpers,
RawDocType,
'distinct',
TInstanceMethods
>;

/** Specifies a `$elemMatch` query condition. When called with one argument, the most recent path passed to `where()` is used. */
elemMatch<K = string>(path: K, val: any): this;
Expand Down
20 changes: 20 additions & 0 deletions types/utility.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,26 @@ declare module 'mongoose' {
type IfAny<IFTYPE, THENTYPE, ELSETYPE = IFTYPE> = 0 extends (1 & IFTYPE) ? THENTYPE : ELSETYPE;
type IfUnknown<IFTYPE, THENTYPE> = unknown extends IFTYPE ? THENTYPE : IFTYPE;

type WithLevel1NestedPaths<T, K extends keyof T = keyof T> = {
[P in K | NestedPaths<Required<T>, K>]: P extends K
? T[P]
: P extends `${infer Key}.${infer Rest}`
? Key extends keyof T
? Rest extends keyof NonNullable<T[Key]>
? NonNullable<T[Key]>[Rest]
: never
: never
: never;
};

type NestedPaths<T, K extends keyof T> = K extends string
? T[K] extends Record<string, any> | null | undefined
? `${K}.${keyof NonNullable<T[K]> & string}`
: never
: never;

type WithoutUndefined<T> = T extends undefined ? never : T;

/**
* @summary Removes keys from a type
* @description It helps to exclude keys from a type
Expand Down