Netlify functions example #11892
Merged
Netlify functions example #11892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Jun 6, 2022
Collaborator
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
Bunch of comments. Also, let's add some test cases.
examples/netlify-functions/functions/getProducts/getProducts.js
Outdated
Show resolved
Hide resolved
examples/netlify-functions/functions/removeFromCart/removeFromCart.js
Outdated
Show resolved
Hide resolved
vkarpov15
reviewed
Jun 13, 2022
examples/ecommerce-netlify-functions/functions/removeFromCart.js
Outdated
Show resolved
Hide resolved
vkarpov15
requested changes
Jul 1, 2022
vkarpov15
requested changes
Jul 17, 2022
Collaborator
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
I made a couple of quick changes, but still have a few more suggestions. But this is almost ready to go pending a couple of small fixes.
examples/ecommerce-netlify-functions/netlify/functions/addToCart.js
Outdated
Show resolved
Hide resolved
examples/ecommerce-netlify-functions/netlify/functions/checkout.js
Outdated
Show resolved
Hide resolved
vkarpov15
reviewed
Jul 20, 2022
| mongodbUri: 'mongodb://localhost:27017/ecommerce', | ||
| stripeSecretKey: 'YOUR STRIPE KEY HERE' | ||
| stripeSecretKey: 'YOUR STRIPE KEY HERE', | ||
| success_url: 'localhost:3000/success', |
Collaborator
There was a problem hiding this comment.
👎 camelCase, no snake_case
vkarpov15
reviewed
Jul 20, 2022
| productName: String, | ||
| productPrice: Number | ||
| name: String, | ||
| price: Number, |
Collaborator
There was a problem hiding this comment.
Didn't update tests to reflect this change
vkarpov15
approved these changes
Jul 20, 2022
Collaborator
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
Gonna merge this and get it into mongoosejs/sample-apps for future work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not done