Charts: Support HSL, RGB, and RGBA theme colors (CHARTS-138) #46349

Copilot · 2025-12-18T01:00:28Z

Fixes https://linear.app/a8c/issue/CHARTS-138/support-hsl-rgb-and-rgba-theme-colors

Proposed changes:

Add support for HSL, RGB, and RGBA color formats in theme colors (previously only hex colors were supported)
Update normalizeColorToHex to handle rgba() colors in addition to rgb() and hsl()
Refactor color cache building in global-charts-provider.tsx to use normalizeColorToHex for all color processing
Add comprehensive test coverage for new color format support

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://linear.app/a8c/review/charts-add-global-theme-support-for-generating-colors-from-a-single-842566402164#comment-ce4ba572

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Setup

Navigate to the charts package: cd projects/js-packages/charts
Install dependencies: pnpm install

Verify the fix

Run tests to verify all color formats are supported: pnpm test
- All 667 tests should pass
- Look for new tests in chart-context.test.tsx covering RGB, HSL, and RGBA formats
Run the build: pnpm run build
- Build should complete successfully
Run type checking: pnpm run typecheck
- No type errors should be reported

Technical details

Before this change: CSS variables resolving to rgb(), rgba(), or hsl() were silently skipped during color cache building because the code only checked for colors starting with #.

After this change: All color formats are normalized using normalizeColorToHex, which:

Resolves CSS variables using resolveCssVariable
Converts RGB, RGBA, and HSL to hex format using d3-color
Handles 3-digit hex expansion (e.g., #bad → #bbaadd)
Supports all browser-returned color formats

Note: Alpha channel information in RGBA colors is lost during hex conversion (this is expected d3-color behavior).

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

github-actions · 2025-12-18T01:02:13Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

- Updated global-charts-provider to use normalizeColorToHex for all color processing - Added support for RGB, RGBA, and HSL color formats in theme colors - Updated normalizeColorToHex to handle rgba() colors (previously rejected) - Added comprehensive tests for RGB, HSL, and RGBA color support - Updated existing tests to reflect new color normalization behavior Fixes: https://linear.app/a8c/issue/CHARTS-138

adamwoodnz · 2025-12-18T01:25:34Z

@copilot try to commit again. I have updated your firewall allowlist

Copilot · 2025-12-18T01:26:54Z

@copilot try to commit again. I have updated your firewall allowlist

The commit has been successfully pushed! The branch is now up to date with all changes for CHARTS-138, including:

Support for HSL, RGB, and RGBA color formats
Updated tests (all 667 passing)
Changelog entry

Commit: 7cd8804

adamwoodnz · 2025-12-18T01:28:48Z

@copilot the description needs to follow .github/PULL_REQUEST_TEMPLATE.md

github-actions · 2025-12-18T01:31:47Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the copilot/support-hsl-rgb-rgba-colors branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack copilot/support-hsl-rgb-rgba-colors

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copilot · 2025-12-18T01:32:02Z

@copilot the description needs to follow .github/PULL_REQUEST_TEMPLATE.md

Updated the PR description to follow the template format with proper sections including Fixes, Proposed changes, Testing instructions, and other required fields.

jp-launch-control · 2025-12-18T01:45:47Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/charts/src/providers/chart-context/global-charts-provider.tsx	81/82 (98.78%)	-1.22%	1 ❤️‍🩹
projects/js-packages/charts/src/utils/color-utils.ts	69/70 (98.57%)	1.35%	-1 💚

Full summary · PHP report · JS report

Copilot

Pull request overview

This PR adds support for HSL, RGB, and RGBA color formats in theme colors, where previously only hex colors were supported. This fix resolves an issue where CSS variables resolving to non-hex color formats were silently skipped during color cache building.

Key Changes:

Extended normalizeColorToHex to handle rgba() colors in addition to existing rgb() and hsl() support
Refactored color cache building in GlobalChartsProvider to use normalizeColorToHex for all color processing, ensuring consistent handling across all color formats
Added comprehensive test coverage for new RGBA format support and CSS variables resolving to RGB/HSL/RGBA values

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`projects/js-packages/charts/src/utils/color-utils.ts`	Added `rgba()` to the list of supported color formats in `normalizeColorToHex` and updated documentation in `parseRgbString` to clarify it only handles RGB (not RGBA)
`projects/js-packages/charts/src/utils/test/color-utils.test.ts`	Added comprehensive tests for RGBA color conversion including edge cases with alpha channel and fully transparent colors
`projects/js-packages/charts/src/providers/chart-context/global-charts-provider.tsx`	Refactored color cache building to use `normalizeColorToHex` for all color processing, replacing manual CSS variable resolution with centralized normalization
`projects/js-packages/charts/src/providers/chart-context/test/chart-context.test.tsx`	Added integration tests for CSS variables resolving to RGB, HSL, and RGBA formats, and updated existing test expectations to reflect 3-digit hex expansion behavior
`projects/js-packages/charts/changelog/charts-138-support-hsl-rgb-rgba-colors`	Added changelog entry documenting the new color format support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Initial plan

392e97c

Copilot AI assigned Copilot and adamwoodnz Dec 18, 2025

Copilot started work on behalf of adamwoodnz December 18, 2025 01:00 View session

github-actions bot added the [Status] In Progress label Dec 18, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 18, 2025

Copilot AI requested a review from adamwoodnz December 18, 2025 01:18

Copilot started work on behalf of adamwoodnz December 18, 2025 01:26 View session

Copilot finished work on behalf of adamwoodnz December 18, 2025 01:27

Copilot started work on behalf of adamwoodnz December 18, 2025 01:30 View session

github-actions bot added [JS Package] Charts [Tests] Includes Tests RNA labels Dec 18, 2025

Copilot AI changed the title ~~[WIP] Add support for hsl, rgb, and rgba theme colors~~ Support HSL, RGB, and RGBA theme colors (CHARTS-138) Dec 18, 2025

Copilot finished work on behalf of adamwoodnz December 18, 2025 01:33

adamwoodnz added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 18, 2025

adamwoodnz changed the title ~~Support HSL, RGB, and RGBA theme colors (CHARTS-138)~~ Charts: Support HSL, RGB, and RGBA theme colors (CHARTS-138) Dec 18, 2025

adamwoodnz requested a review from Copilot December 18, 2025 01:51

Copilot started reviewing on behalf of adamwoodnz December 18, 2025 01:51 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Charts: Support HSL, RGB, and RGBA theme colors (CHARTS-138) #46349

Charts: Support HSL, RGB, and RGBA theme colors (CHARTS-138) #46349

Copilot AI commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

adamwoodnz commented Dec 18, 2025

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

adamwoodnz commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

jp-launch-control bot commented Dec 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Charts: Support HSL, RGB, and RGBA theme colors (CHARTS-138) #46349

Are you sure you want to change the base?

Charts: Support HSL, RGB, and RGBA theme colors (CHARTS-138) #46349

Conversation

Copilot AI commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Setup

Verify the fix

Technical details

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamwoodnz commented Dec 18, 2025

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

adamwoodnz commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

jp-launch-control bot commented Dec 18, 2025

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading