-
Notifications
You must be signed in to change notification settings - Fork 843
Agent Manager: add admin bar icon #46343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Duplicates help center code to add an admin bar icon. Removes existing help center icon, making the agent manager take over. Add
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
Coverage check overridden by
I don't care about code coverage for this PR
|
Duplicates the help center code to add an admin bar icon. This removes any existing help center icon so only one icon is shown. This is one step towards moving everything to the agent manager.
This change should have no effect if you are not using the unified experience.
Note this requires Automattic/wp-calypso#107655 which will need to be deployed first.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
document.querySelector( '#wp-admin-bar-agents-manager' )returns the ? icon, anddocument.querySelector( '#wp-admin-bar-help-center' )returns nothing