Skip to content

Scan: Replace inline onclick with target="_blank" for CSP compliance #46340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmjuhasz wants to merge 2 commits into
base: trunk
Choose a base branch
from
+9 −4
Open

Scan: Replace inline onclick with target="_blank" for CSP compliance #46340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1f5fe5
Scan: Replace inline onclick with target="_blank" for CSP compliance
gmjuhasz Dec 17, 2025
0b015f4
Add rel="noopener noreferrer" for security best practice
gmjuhasz Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/JETPACK-1146
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Scan: Replace inline onclick handler with target="_blank" for CSP compliance in admin bar notice.
9 changes: 5 additions & 4 deletions projects/plugins/jetpack/modules/scan/class-admin-bar-notice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,11 @@ public function add_threats_to_toolbar( $wp_admin_bar ) {
);

if ( $has_threats ) {
$node['href'] = esc_url( Redirect::get_url( 'calypso-scanner' ) );
$node['meta']['onclick'] = 'window.open( this.href ); return false;';
$node['meta']['class'] = 'error';
$node['title'] = sprintf(
$node['href'] = esc_url( Redirect::get_url( 'calypso-scanner' ) );
$node['meta']['target'] = '_blank';
$node['meta']['rel'] = 'noopener noreferrer';
$node['meta']['class'] = 'error';
$node['title'] = sprintf(
esc_html(
/* translators: %s is the alert icon */
_n( '%s Threat found', '%s Threats found', $this->get_threat_count(), 'jetpack' )
Expand Down
Loading