Skip to content

Conversation

@manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Dec 17, 2025

We allow users to click on the "Share" link from the post list screen which redirects to the editor with resharing modal open.

We need to update that logic to make it work with the unified modal via the feature flag.

Related to #46323

Closes SOCIAL-277

Proposed changes:

  • Update handleSharePostAction to open the unified modal when the UNIFIED_UI_V1 feature is enabled, otherwise fallback to the original share post modal.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Activate Social plugin or add this snipped somewhere
add_filter('jetpack_post_list_display_share_action', '__return_true', 20 );
  • Go to post list page
  • Hover over a published post
  • Click on "Share" action
  • Confirm that it opens the editor with unified share post modal open

Updated handleSharePostAction to open the unified modal when the UNIFIED_UI_V1 feature is enabled, otherwise fallback to the original share post modal.
@manzoorwanijk manzoorwanijk requested review from a team and Copilot December 17, 2025 10:19
@manzoorwanijk manzoorwanijk self-assigned this Dec 17, 2025
@manzoorwanijk manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/social/integrate-post-list-share-action-n-unified-modal branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/social/integrate-post-list-share-action-n-unified-modal

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates the post list share action with the unified modal by updating the handleSharePostAction function to conditionally use the new unified modal when the UNIFIED_UI_V1 feature flag is enabled.

Key Changes

  • Added feature flag check to conditionally open either the unified modal or the legacy share post modal
  • Imported necessary dependencies (siteHasFeature and features) to support the feature flag logic
  • Added changelog entry documenting this integration

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
projects/js-packages/publicize-components/src/components/block-editor/shared-utils.ts Updated handleSharePostAction to check the UNIFIED_UI_V1 feature flag and call openUnifiedModal() when enabled, otherwise fallback to openSharePostModal()
projects/js-packages/publicize-components/changelog/update-social-integrate-post-list-share-action-n-unified-modal Added changelog entry documenting this patch-level change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/js-packages/publicize-components/src/components/block-editor/shared-utils.ts 0/7 (0.00%) 0.00% 3 ❤️‍🩹

Full summary · PHP report · JS report

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with the feature flag, and also compatible with sites not having it

@manzoorwanijk manzoorwanijk merged commit 551d9f0 into trunk Dec 17, 2025
91 of 94 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social/integrate-post-list-share-action-n-unified-modal branch December 17, 2025 10:46
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components RNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants