CHARTS-33: Allow glyphs to be defined from theme #43875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use @visx/group Group component for legend glyphs - Add defaultRenderGlyph fallback for legend - Fix tooltip type compatibility with DataPointDate - Pass glyphStyle props consistently across components
…phs can be different
This reverts commit f077c84.
This reverts commit 988168f.
This reverts commit 024d16a.
This reverts commit 37425c2.
There was a problem hiding this comment.
Pull Request Overview
This PR extends the chart theming API to let consumers declare a list of glyph-rendering functions in their theme and applies those glyphs per series (including tooltips), plus updates stories and changelog to demonstrate the feature.
- Added an optional
glyphsarray toChartTheme - Extracted
DefaultGlyphinto its own component and wired theme glyphs intoLineChart - Updated Storybook stories to showcase theme-based glyph overrides
- Recorded a changelog entry for the new feature
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/js-packages/charts/src/types.ts | Added glyphs property to ChartTheme |
| projects/js-packages/charts/src/components/shared/default-glyph.tsx | Extracted the default glyph renderer into its own file |
| projects/js-packages/charts/src/components/line-chart/stories/index.stories.tsx | Demonstrated custom theme glyphs and added themeName control |
| projects/js-packages/charts/src/components/line-chart/line-chart.tsx | Integrated theme glyphs for start markers, series, and tooltips |
| projects/js-packages/charts/changelog/charts-package-glyphs-theme | Added changelog entry |
Comments suppressed due to low confidence (2)
projects/js-packages/charts/src/types.ts:103
- [nitpick] Consider expanding the doc comment to explain how
glyphsindices map to data series and what happens when fewer glyph functions than series are provided.
glyphs?: Array< < Datum extends object >( props: GlyphProps< Datum > ) => ReactNode >;
projects/js-packages/charts/src/components/line-chart/line-chart.tsx:239
- No tests currently verify that the
tooltipRenderGlyphoverride correctly picks theme glyphs per series. Add unit or integration tests to cover custom tooltip glyph behavior.
const tooltipRenderGlyph = useMemo( () => {
projects/js-packages/charts/src/components/line-chart/stories/index.stories.tsx
Outdated
Show resolved
Hide resolved
Nikschavan
changed the title
Nikschavan
added
the
Coverage tests to be added later
Nikschavan
changed the title
kangzj
previously approved these changes
Jun 16, 2025
github-actions
bot
removed
[Status] Needs Author Reply
This was referenced Jun 17, 2025
mikestottuk
pushed a commit
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CHARTS-33
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions: