Charts: Refactor withResponsive HOC to Allow Custom Responsive Config for Chart Component
#43871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `maxWidth`, `aspectRatio`, and `resizeDebounceTime` properties across BarChart, LineChart, PieChart, and PieSemiCircleChart story files. - Updated the `withResponsive` higher-order component to utilize these new properties for better responsive behavior. - Enhanced tests to validate the application of these new configurations.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
bot
added
the
[Status] Needs Author Reply
chihsuan
added
[Type] Enhancement
Code Coverage SummaryCoverage changed in 1 file.
|
chihsuan
deleted the
charts-28-enhance-responsive-handling-for-chart-components
branch
github-actions
bot
removed
the
[Status] Needs Review
mikestottuk
pushed a commit
that referenced
this pull request
Jun 26, 2025
…ig for Chart Component (#43871) * Add responsive configuration options for charts - Introduced `maxWidth`, `aspectRatio`, and `resizeDebounceTime` properties across BarChart, LineChart, PieChart, and PieSemiCircleChart story files. - Updated the `withResponsive` higher-order component to utilize these new properties for better responsive behavior. - Enhanced tests to validate the application of these new configurations. * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CHARTS-28
Proposed changes:
Previously, all chart components were exported only as versions wrapped with the
withResponsivehigher-order component (HOC), with responsive configuration (e.g., aspectRatio, maxWidth, resizeDebounceTime) set statically at the time of wrapping. This prevented consumers from customizing responsive behavior for their specific use cases.This PR refactors the
withResponsiveHOC to allow consumers to pass custom responsive configuration props (aspectRatio, maxWidth, resizeDebounceTime, etc.) directly to the wrapped chart components. Now, consumers can easily adjust responsive behavior per instance.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Screen.Recording.2025-06-10.at.15.46.00.mov