-
Notifications
You must be signed in to change notification settings - Fork 823
VideoPress: Fix other files not getting uploaded when there is a Video file among dragged files #42312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
|
@CGastrell could you help review this VideoPress PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on all my tests, thanks for taking care of this!
a2816a7
to
0a5c226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on all the described scenarios. 🚢
Good job. 👍
Fixes #40469
Proposed changes:
We found that the transformation added here #32084 was causing the issue. basically we filtered out the Video files with a higher priority and transformed them only. So all the other files got stranded and didn't get dropped in the editor.
Now we transform the video files like before, but additionally, we find out the proper transformation for the other files as well and apply them.
Other information:
Testing instructions:
Does this pull request change what data or activity we track or use?
No