-
Notifications
You must be signed in to change notification settings - Fork 826
wpcom Features: add new Holiday Snow feature #40478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit brings a new feature to the mu-wpcom package: - That feature can be toggled via Settings > General in wp-admin. - It is active from December 1st to January 4th by default.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests beautifully
Follow-up to #40478 The snowstorm library we use to display falling snow is not compatible with p2s. Let's consequently not offer the option to turn on snow on p2s.
* Holiday snow: do not display on p2 Follow-up to #40478 The snowstorm library we use to display falling snow is not compatible with p2s. Let's consequently not offer the option to turn on snow on p2s. * changelog
* Holiday snow: do not display on p2 Follow-up to #40478 The snowstorm library we use to display falling snow is not compatible with p2s. Let's consequently not offer the option to turn on snow on p2s. * changelog
Proposed changes:
This PR brings a new feature to the mu-wpcom package:
Other information:
Jetpack product discussion
https://github.com/Automattic/dotcom-forge/issues/10082
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Note
This can be tested on WordPress.com (Simple and WoA)
When testing on WoA, add the following to your site's
wp-config.php
file::site:/wp-admin/options-general.php
)If you do not use the classic interface for that site in your WordPress.com settings, you can test in calypso using this Calypso PR:
Automattic/wp-calypso#97127