Skip to content

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 5, 2024

Proposed changes:

This PR brings a new feature to the mu-wpcom package:

  • That feature can be toggled via Settings > General in wp-admin.
  • It is active from December 1st to January 4th by default.
image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/dotcom-forge/issues/10082

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Note

This can be tested on WordPress.com (Simple and WoA)
When testing on WoA, add the following to your site's wp-config.php file:

define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
define( 'JETPACK_AUTOLOAD_DEV', true );
  1. After adding the branch to your test site,
  2. Go to Settings > General (:site:/wp-admin/options-general.php)
  3. Toggle the feature on (it should be off by default)
  4. Visit the site's frontend
    • You should see snow falling
  5. Toggle the feature off and save your changes
    • The snow should be gone.

If you do not use the classic interface for that site in your WordPress.com settings, you can test in calypso using this Calypso PR:
Automattic/wp-calypso#97127

This commit brings a new feature to the mu-wpcom package:

- That feature can be toggled via Settings > General in wp-admin.
- It is active from December 1st to January 4th by default.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal labels Dec 5, 2024
@jeherve jeherve self-assigned this Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/holiday-snow branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/holiday-snow
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/holiday-snow
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [mu wpcom Feature] Holiday Snow labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve jeherve added [Status] Needs Review This PR is ready for review. [Plugin] mu wpcom jetpack-mu-wpcom plugin and removed [Status] In Progress labels Dec 6, 2024
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests beautifully

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 6, 2024
@jeherve jeherve merged commit d416736 into trunk Dec 6, 2024
83 of 84 checks passed
@jeherve jeherve deleted the add/holiday-snow branch December 6, 2024 15:29
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 6, 2024
jeherve added a commit that referenced this pull request Dec 9, 2024
Follow-up to #40478

The snowstorm library we use to display falling snow is not compatible with p2s. Let's consequently not offer the option to turn on snow on p2s.
@jeherve jeherve mentioned this pull request Dec 9, 2024
3 tasks
jeherve added a commit that referenced this pull request Dec 9, 2024
* Holiday snow: do not display on p2

Follow-up to #40478

The snowstorm library we use to display falling snow is not compatible with p2s. Let's consequently not offer the option to turn on snow on p2s.

* changelog
IanRamosC pushed a commit that referenced this pull request Dec 9, 2024
* Holiday snow: do not display on p2

Follow-up to #40478

The snowstorm library we use to display falling snow is not compatible with p2s. Let's consequently not offer the option to turn on snow on p2s.

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[mu wpcom Feature] Holiday Snow [Package] Jetpack mu wpcom WordPress.com Features [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Pri] Normal [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants