Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo Gardening: add check for a [Type] label on PRs #40428

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Repo Gardening: add check for a [Type] label on PRs #40428

merged 3 commits into from
Dec 3, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 3, 2024 •
edited
Loading

Proposed changes:

Let's start recommending to PR authors that they include a [Type] label in their PR.

image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-uPQ-p2#comment-74890

Does this pull request change what data or activity we track or use?

No

Testing instructions:

This can be tested in a fork. Here is an example:

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project labels Dec 3, 2024
@jeherve jeherve self-assigned this Dec 3, 2024
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Dec 3, 2024
@jeherve jeherve requested a review from a team December 3, 2024 13:51
anomiex
anomiex previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

projects/github-actions/repo-gardening/src/tasks/check-description/index.js Outdated
hasTesting,
hasPrivacy,
projectsWithoutChangelog,
hasChangelogEntries: projectsWithoutChangelog.length === 0,
isFromContributor,
hasTypeLabels,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably move this up next to hasStatusLabels, but it doesn't really matter.

Copy link
Member Author

@jeherve jeherve Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Done in 0dc30d4

@jeherve @anomiex
Move it up for more readability
0dc30d4 
See #40428 (comment)

Co-authored-by: anomiex <anomiex@users.noreply.github.com>
@jeherve jeherve merged commit eafa13a into trunk Dec 3, 2024
55 checks passed
@jeherve jeherve deleted the add/repo-gardening-type-label-check-pr branch December 3, 2024 15:15
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 3, 2024
matticbot pushed a commit to Automattic/action-repo-gardening that referenced this pull request Dec 3, 2024
@jeherve @matticbot
Repo Gardening: add check for a [Type] label on PRs (#40428)
0a088eb 
* Repo Gardening: add check for a [Type] label on PRs

See p1HpG7-uPQ-p2#comment-74890

* Avoid an additional call to get all labels

* Move it up for more readability

See Automattic/jetpack#40428 (comment)

Co-authored-by: anomiex <anomiex@users.noreply.github.com>

---------

Co-authored-by: anomiex <anomiex@users.noreply.github.com>

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12142627587

Upstream-Ref: Automattic/jetpack@eafa13a
matticbot pushed a commit to Automattic/jetpack-storybook that referenced this pull request Dec 3, 2024
@jeherve @matticbot
Repo Gardening: add check for a [Type] label on PRs (#40428)
a7893b2 
* Repo Gardening: add check for a [Type] label on PRs

See p1HpG7-uPQ-p2#comment-74890

* Avoid an additional call to get all labels

* Move it up for more readability

See Automattic/jetpack#40428 (comment)

Co-authored-by: anomiex <anomiex@users.noreply.github.com>

---------

Co-authored-by: anomiex <anomiex@users.noreply.github.com>

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12142627587

Upstream-Ref: Automattic/jetpack@eafa13a
jeherve added a commit that referenced this pull request Dec 4, 2024
@jeherve
Repo Gardening: add Type labels to PRs based off changelog entries
895bc38 
Follow-up to #40428.

Let's try to automate the addition of "Type" labels to each PR.

When PR includes changelog files, and when that PR does not already has a [Type] label, let's scan the contents of the changelog files, pick the first "Type" definition we can find, and match that to one of our existing Type labels.
@jeherve jeherve mentioned this pull request Dec 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@jeherve jeherve

Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeherve @anomiex