-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Assistant: Add disclaimer to image generation input #40397
AI Assistant: Add disclaimer to image generation input #40397
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
About the positioning, let's try to use the bottom area with a message that is more contextual to the image generation. Here examples for the general image generation modal: ![]() And for the logo generation modal: ![]() cc @dhasilva |
35b33a8
to
0f5f8db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer appears on all image generation modals 🚀
@dhasilva LGTM! Just a minor thing, can we be sure the external icon we use is consistent with this one, for example? ![]() I'm not sure if we are using the same character there 🤔 |
…age-generator-input-disclaimer
Fixes #
Proposed changes:
This is an attempt to address feedback, as some people get frustrated with text errors that are beyond the capability of current models and maybe they are expecting it to work perfectly.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
You can also run Storybook locally with
( cd projects/js-packages/storybook && pnpm run storybook:dev --no-open --debug-webpack )
and visitinghttp://localhost:50240/?path=/docs/js-packages-ai-client-aimodalfooter--docs