Gardening: update conditions to include "[<plugin> Feature]" labels #40396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our standalone plugins do not use [Feature] labels ; they use [PluginName Feature] labels instead. Let's update our conditions to be happy with such labels as well. This commit also makes the priority condition a bit more broad, so it is satisfied with both "[Pri]" and "[Priority]" labels.
jeherve
added
[Type] Enhancement
jeherve
force-pushed
the
update/repo-gardening-label-type-catch
branch
from
45b079b to
f68d7de
Compare
jeherve
changed the title
jeherve
added
[Status] Needs Review
jeherve
requested review from
anomiex and
a team
and removed request for
anomiex
github-actions
bot
added
the
[Action] Repo Gardening
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
anomiex
reviewed
Dec 2, 2024
| @@ -152,9 +152,9 @@ async function triageIssues( payload, octokit ) { | |||
| const issueLabels = await aiLabeling( payload, octokit ); | |||
|
|
|||
| // At this point, if we still miss a [Type] label, a [Feature] label, or a [Pri] label, ask the author to add it. | |||
| const requiredLabelTypes = [ '[Type]', '[Feature', '[Pri]' ]; | |||
| const requiredLabelTypes = [ /^\[Type\]/, /^\[Pri/, /^\[.*?Feature/ ]; | |||
There was a problem hiding this comment.
Did you intend to leave off the \] from [Pri]?
Also, it might be good to avoid potentially matching something like [Type] Feature Request.
Suggested change
| const requiredLabelTypes = [ /^\[Type\]/, /^\[Pri/, /^\[.*?Feature/ ]; | |
| const requiredLabelTypes = [ /^\[Type\]/, /^\[Pri\]/, /^\[[^\]]*Feature/ ]; |
There was a problem hiding this comment.
Did you intend to leave off the ] from [Pri]?
I did, yes, I figured it'd be useful so we can catch [Priority] for repos that don't use the shorthand.
it might be good to avoid potentially matching something like [Type] Feature Request.
Good point. Done in f0313eb
anomiex
approved these changes
Dec 2, 2024
github-actions
bot
removed
the
[Status] Needs Review
matticbot
pushed a commit
to Automattic/action-repo-gardening
that referenced
this pull request
Dec 3, 2024
…#40396) * Gardening: update conditions to include "[<plugin> Feature]" labels Some of our standalone plugins do not use [Feature] labels ; they use [PluginName Feature] labels instead. Let's update our conditions to be happy with such labels as well. This commit also makes the priority condition a bit more broad, so it is satisfied with both "[Pri]" and "[Priority]" labels. * Avoid catching [Type] Feature request See Automattic/jetpack#40396 (comment) --------- Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12138232773 Upstream-Ref: Automattic/jetpack@4583fe6
matticbot
pushed a commit
to Automattic/jetpack-storybook
that referenced
this pull request
Dec 3, 2024
…#40396) * Gardening: update conditions to include "[<plugin> Feature]" labels Some of our standalone plugins do not use [Feature] labels ; they use [PluginName Feature] labels instead. Let's update our conditions to be happy with such labels as well. This commit also makes the priority condition a bit more broad, so it is satisfied with both "[Pri]" and "[Priority]" labels. * Avoid catching [Type] Feature request See Automattic/jetpack#40396 (comment) --------- Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12138232773 Upstream-Ref: Automattic/jetpack@4583fe6
jeherve
added a commit
that referenced
this pull request
Dec 3, 2024
Just like in #40396, we want to allow the AI labeler to pull plugin-specific labels as well.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Some of our standalone plugins do not use [Feature] labels ; they use [PluginName Feature] labels instead. Let's update our conditions to be happy with such labels as well.
This commit also makes the priority condition a bit more broad, so it is satisfied with both "[Pri]" and "[Priority]" labels.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
This can only be tested in a fork, where you'll merge this branch into
trunk, then create an issue with no content and the "[Priority] High", "[Type] Bug", and "[Boost Feature] Cloud CSS" labels. No commment prompting for labels should get posted.