-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter sidebar: fix no space under toggle #40376
Conversation
- Fix no space under toggle - Opt-in into 40px default size for the toggle - Add accessibility label
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Thank you 🙏 |
Keeping the componentry up to latest Gutenberg changes.
In pre/post publish panels
p
tags have 1em top/bottom margin so__nextHasNoMarginBottom
for the toggle component works fine, but in Newsletter sidebar it didn't.Note also slightly bigger toggle size, which will be the default in future Gutenberg.
Proposed changes:
Couple small fixes:
Before
After
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: