Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social | Migrate remaining settings to script data #40081

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Social | Migrate remaining settings to script data #40081

merged 8 commits into from
Nov 11, 2024

Conversation

manzoorwanijk
Copy link
Member

This is the last PR for our initial state migration 🎉

Proposed changes:

  • Remove the siteData related reducer and selectors
  • Flip the initial state for the social store from old data to the new script data
  • Clean things up a bit

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Disconnect Jetpack from My Jetpack, if already connected
  • Goto Social admin page
  • Click Get Started and complete the connection
  • Confirm that the connection is successful
  • From the Jetpack Settings page, Social admin page and the editor, cConfirm that the connections are loaded fine on the initial page load
  • Confirm that share status loads fine

@manzoorwanijk manzoorwanijk requested a review from a team November 7, 2024 09:00
@manzoorwanijk manzoorwanijk self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-migrate-remaining-settings-to-script-data branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-migrate-remaining-settings-to-script-data

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

manzoorwanijk
manzoorwanijk commented Nov 7, 2024
View reviewed changes
projects/plugins/social/src/js/components/connection-screen/index.js
Comment on lines -12 to 14
const connectProps = useSelect( select => {
const store = select( SOCIAL_STORE_ID );
return {
apiRoot: store.getAPIRootUrl(),
apiNonce: store.getAPINonce(),
registrationNonce: store.getRegistrationNonce(),
};
} );

const { userIsConnecting, siteIsRegistering, handleRegisterSite, registrationError } =
useConnection( {
from: 'jetpack-social',
redirectUri: 'admin.php?page=jetpack-social',
...connectProps,
} );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those props passed to useConnection are optional and it uses its own local props as default. So, we don't need to pass those.

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Nov 7, 2024
pablinos
pablinos approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me, just had a small query about the change to the type.

projects/js-packages/publicize-components/src/social-store/types.ts
@@ -3,6 +3,7 @@ export type ConnectionStatus = 'ok' | 'broken';
export type Connection = {
id: string;
service_name: string;
label?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of a bug fix? It doesn't seem necessary for the refactor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was needed after renaming files to .ts because we use that in some TS files and that label refers to service label - messed up schema 😄

@manzoorwanijk manzoorwanijk merged commit 11d94d0 into trunk Nov 11, 2024
60 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social-migrate-remaining-settings-to-script-data branch November 11, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablinos pablinos pablinos approved these changes

Assignees

@manzoorwanijk manzoorwanijk

Labels
Admin Page React-powered dashboard under the Jetpack menu [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manzoorwanijk @pablinos