Skip to content

Conversation

sergeymitr
Copy link
Contributor

@sergeymitr sergeymitr commented Nov 6, 2024

Proposed changes:

Remove old migration code for legacy Gallery and Image widgets.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/529
p9dueE-56-p2
p1730913512335599-slack-C05PV073SG3

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Make sure the tests pass.
  2. Try using one of the widgets from the Widget module in a post, confirm it renders well.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/optimize-widget-migration-hooks branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/optimize-widget-migration-hooks
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Extra Sidebar Widgets [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve
Copy link
Member

jeherve commented Nov 6, 2024

Instead of updating the logic, should we consider removing it entirely? Those migrations were introduced 7 and 8 years ago. Maybe we can stop trying to migrate folks today, and assume that folks who needed to migrated have migrated already?
Given that the 2 core widgets we attempt to migrate to (image and gallery) are now legacy widgets (focus is on blocks instead), I think it makes even less sense to keep the migration to legacy widgets around.

@sergeymitr sergeymitr changed the title Jetpack: optimize widget migration hooks Jetpack: remove old widget migration code Nov 6, 2024
@sergeymitr sergeymitr merged commit 7f331f7 into trunk Nov 6, 2024
60 of 62 checks passed
@sergeymitr sergeymitr deleted the update/optimize-widget-migration-hooks branch November 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extra Sidebar Widgets [Focus] Performance [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants