-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack: Stats: Fix csv trailing newline handling #39787
Conversation
When #39665 switched from incorrectly using `str_getcsv( $csv, "\n" )` to `explode()`, a minor difference between the two was unnoticed: the former does not produce an empty element at the end of the result on a trailing newline, while the latter does. Add an `rtrim` on the data to ensure there isn't a trailing newline.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Proposed changes:
When #39665 switched from incorrectly using
str_getcsv( $csv, "\n" )
toexplode()
, a minor difference between the two was unnoticed: the former does not produce an empty element at the end of the result on a trailing newline, while the latter does.Add an
rtrim
on the data to ensure there isn't a trailing newline.Other information:
Jetpack product discussion
p1729086256595799/1729061294.312889-slack-C034JEXD1RD
Does this pull request change what data or activity we track or use?
Testing instructions:
/wp-admin/admin.php?page=stats&noheader=1&dashboard=1
seems to do it. Note you also need at least some visits to the site. You'll also have to make sure the 'stats_cache' option is cleared.