-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Check that React-using projects use react eslint rules #39214
Conversation
I noticed that several of our projects are using React but did not have our `jetpack-js-tools/eslintrc/react` eslint ruleset enabled. This adds a linting check for that, and enables it on most of the projects where it was not enabled. For a few I instead added a `@todo` comment about turning it on, due to a lot of cleanup being needed in order to successfully do so. I hope people more familiar with React and these projects will follow up on that. * js-packages/ai-client: 32 × react/jsx-no-bind 33 × react-hooks/exhaustive-deps * packages/videopress: 8 × react-hooks/rules-of-hooks 69 × react-hooks/exhaustive-deps 157 × react/jsx-no-bind * plugins/boost: 1 × react/no-danger 81 × react/jsx-no-bind * plugins/crm: 1 × react-hooks/rules-of-hooks 2 × react/jsx-no-bind 3 × react-hooks/exhaustive-deps
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
I noticed that several of our projects are using React but did not have our `jetpack-js-tools/eslintrc/react` eslint ruleset enabled. This adds a linting check for that, and enables it on most of the projects where it was not enabled. For a few I instead added a `@todo` comment about turning it on, due to a lot of cleanup being needed in order to successfully do so. I hope people more familiar with React and these projects will follow up on that. * js-packages/ai-client: 32 × react/jsx-no-bind 33 × react-hooks/exhaustive-deps * packages/videopress: 8 × react-hooks/rules-of-hooks 69 × react-hooks/exhaustive-deps 157 × react/jsx-no-bind * plugins/boost: 1 × react/no-danger 81 × react/jsx-no-bind * plugins/crm: 1 × react-hooks/rules-of-hooks 2 × react/jsx-no-bind 3 × react-hooks/exhaustive-deps
Proposed changes:
I noticed that several of our projects are using React but did not have our
jetpack-js-tools/eslintrc/react
eslint ruleset enabled. This adds a linting check for that, and enables it on most of the projects where it was not enabled.For a few I instead added a
@todo
comment about turning it on, due to a lot of cleanup being needed in order to successfully do so. I hope people more familiar with React and these projects will follow up on that.Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions:
extends
added here. Does.github/files/lint-project-structure.sh
catch it?