Skip to content

Conversation

dhasilva
Copy link
Contributor

Fixes #39167

Proposed changes:

  • Uses the AI Helper to get feature availability from the backend
  • Checks those values before enabling Write Brief or any individual highlight type

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply this PR to your sandbox (testing locally alone won't work, as the AI helper class needs to be in sync with the backend)
  • Go to the block editor
  • Check that Breve is enabled and all its features (spelling is still under beta flag, check will be removed in a follow-up)
  • Edit the value of write-brief or any of its subfeatures in D160005-code
  • Check that the features are enabled or disabled according to the function

Only Write Brief checks for the function return value, other features will work regardless of their value.

@dhasilva dhasilva requested a review from a team August 30, 2024 17:29
@dhasilva dhasilva self-assigned this Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-get-features-control branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-get-features-control
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA labels Aug 30, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dhasilva dhasilva force-pushed the update/jetpack-ai-get-features-control branch from 8e894d7 to c7a50fe Compare August 30, 2024 19:03
@dhasilva dhasilva enabled auto-merge (squash) August 30, 2024 19:15
@@ -88,6 +88,14 @@ export type TierValueProp =
| Tier750Props[ 'value' ]
| Tier1000Props[ 'value' ];

export type FeatureControl = {
enabled: boolean;
'min-jetpack-version': string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I dreaming? 💯

) ) }
{ features.map(
feature =>
canWriteBriefFeatureBeEnabled( feature.config.name ) && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sub-feature control. Nice!

Copy link
Contributor

@lhkowalski lhkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and is working as expected.

The API response looks great, very well done on adding the default values for older features, as well as using nested features.

When the global "Write Brief" feature is disabled, the section on the UI is gone, as expected:

API Response UI
Screenshot 2024-08-30 at 17 47 20 Screenshot 2024-08-30 at 17 51 56

When some sub-feature of "Write Brief" is disabled, the respective options are gone on the UI, as expected:

API Response UI
Screenshot 2024-08-30 at 17 52 28 Screenshot 2024-08-30 at 17 54 26

An aside: after disabling some sub-features on the backend, I went to the editor and could see them visible for half a second, while the feature data was loaded. This is expected, as you discussed earlier today, and not a problem. We can make it better with loading states in the future, for example.

@dhasilva dhasilva merged commit 77b23eb into trunk Aug 30, 2024
57 checks passed
@dhasilva dhasilva deleted the update/jetpack-ai-get-features-control branch August 30, 2024 21:01
@github-actions github-actions bot added this to the jetpack/13.8 milestone Aug 30, 2024
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Aug 30, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* add features control to ai-assistant-feature endpoint

* check for write brief feature control

* fix FeatureControl type

* apply feature control checks

* changelog

* fix type

* change default to enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Proofread: Control release from backend
2 participants