Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Add Social Share Status modal for published posts #39051
Social: Add Social Share Status modal for published posts #39051
Changes from 9 commits
c560c10
1848811
34f0219
be45e2f
98b4231
efde646
b5eba3a
502b21c
0b3f3d8
a4c4328
82f9e7d
54ae707
1046ce5
5db5551
68b94a9
902fa2c
3c5e987
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to always show everything this part needs to be changed, or removed.
If we want to hide Retry for those that was already retried, we can update the status here to be
retried
or something like that.p1724761254288879/1724758671.904879-slack-C02JJ910CNL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's show the retry button as is and not hide them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let us then leave it as is for now and may be come back later to improve if needed.
I think it does make sense to treat it as activity log.