Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter Preview: Launch (Remove feature flag) #39039

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Newsletter Preview: Launch (Remove feature flag) #39039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ffef5b
remove feature flag
lezama Aug 22, 2024
d8aa51c
changelog
lezama Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-newsletter-preview-feature-flag
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

Adds Gutenberg Newsletter plugin icon to the header, with a plugin sidebar with email preview feature.
3 changes: 1 addition & 2 deletions projects/plugins/jetpack/extensions/blocks/subscriptions/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ registerJetpackBlockFromMetadata( metadata, {
const shouldShowNewsletterMenu = () => {
const postType = select( 'core/editor' ).getCurrentPostType();
const isPost = postType === 'post';
// TODO: Remove the query param check once the feature is stable.
return isPost && new URLSearchParams( window.location.search ).has( 'showNewsletterMenu' );
return isPost;
};

// Registers slot/fill panels defined via settings.render and command palette commands
Expand Down
Loading