Admin bar: move the Reader admin bar item to the secondary group #38976

allilevine · 2024-08-20T17:55:58Z

Fixes Automattic/wp-calypso#93534

Related Calypso PR: Admin bar: Move reader menu item to right section wp-calypso#93749

Proposed changes:

Move the Reader admin bar item to the right side of the admin bar (the secondary group).
Give the Help Center item a priority.

Simple before:

Simple this branch:

Atomic before:

Atomic this branch:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Automattic/wp-calypso#93534

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

To test on WoA, go to the Plugins menu on a WordPress.com Atomic site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/admin-menu-reader-placement branch.
Also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
Go to WP Admin.
Verify that the Reader menu item is on the right, to the left of Help Center.
Check that clicking the Reader item takes you to the Reader.
Test on mobile screen sizes.
Test on supported browsers.
Test with different color schemes.
Test with a RTL language.
Repeat the testing steps with a Simple site. To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/admin-menu-reader-placement

github-actions · 2024-08-20T17:57:03Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen daily.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-08-20T17:57:14Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/admin-menu-reader-placement branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/admin-menu-reader-placement

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

allilevine · 2024-08-20T19:35:23Z

projects/packages/jetpack-mu-wpcom/src/features/help-center/class-help-center.php

@@ -100,7 +100,8 @@ function ( $wp_admin_bar ) {
 							),
 						)
 					);
-				}
+				},
+				119


Order the help center after the Reader, but before Notifications.

allilevine · 2024-08-20T19:37:02Z

projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.php

 				'class' => 'wp-admin-bar-reader',
 			),
+			'parent' => 'top-secondary',


Add the Reader to the secondary admin bar group.

allilevine · 2024-08-20T19:37:39Z

projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.php

-			'href'  => maybe_add_origin_site_id_to_url( 'https://wordpress.com/read' ),
-			'meta'  => array(
+			'id'     => 'reader',
+			'title'  => '<span class="ab-icon" aria-hidden="true"></span><span class="screen-reader-text">' .


I'm following the example of the W logo here.

fushar

Can we fix the gap between Reader and Help Center icon? On >480px mobile width, it seems to have narrower gap than the others:

allilevine · 2024-08-21T17:27:02Z

Can we fix the gap between Reader and Help Center icon? On >480px mobile width, it seems to have narrower gap than the others:

Thanks, I'll take a look!

allilevine · 2024-08-21T19:31:45Z

@fushar I pushed a change, let me know how it looks. I changed both < 782px and < 480px styles to get it to match the Help Center - Notifications gap.

fushar

I pushed a small CSS fix.

It's now pixel perfect with Calypso on various screen widths! Tested on Atomic and Simple as well.

allilevine · 2024-08-22T15:51:30Z

I pushed a small CSS fix.

It's now pixel perfect with Calypso on various screen widths! Tested on Atomic and Simple as well.

Looks great, thanks @fushar!

projects/packages/jetpack-mu-wpcom/src/features/help-center/class-help-center.php

Addison-Stavlo

This looks good to me!

Non blocking - there are minor differences in styles compared to the calypso PR. Note on mobile that there is an extra padding division between the reader and the help center in wp-admin but not calypso. And the calypso one is a little wider. But these are very minor things I wouldn't expect folks to notice.

Addison-Stavlo

WFM! Tested simple and atomic.

allilevine · 2024-08-22T17:07:31Z

Non blocking - there are minor differences in styles compared to the calypso PR. Note on mobile that there is an extra padding division between the reader and the help center in wp-admin but not calypso. And the calypso one is a little wider. But these are very minor things I wouldn't expect folks to notice.

I'll timebox and see if there's a fix.

allilevine · 2024-08-22T18:39:15Z

@Addison-Stavlo I moved the padding to the inner span and I'm now seeing the same width as Calypso, no gap:

Screen.Recording.2024-08-22.at.2.37.32.PM.mov

…ader-placement

fushar

I pushed a small fix. It's now consistent with the corresponding Calypso PR 👍

783px


wp-admin
Calypso

600px


wp-admin
Calypso

400px


wp-admin
Calypso

350px


wp-admin
Calypso

arthur791004

Nice 👍

github-actions bot added [mu wpcom Feature] Help Center [mu wpcom Feature] Wpcom Admin Bar [Package] Jetpack mu wpcom WordPress.com Features [Status] In Progress labels Aug 20, 2024

allilevine force-pushed the update/admin-menu-reader-placement branch from fa4f4e5 to 25460c9 Compare August 20, 2024 18:35

allilevine commented Aug 20, 2024

View reviewed changes

allilevine changed the title ~~Update/admin menu reader placement~~ Admin bar: move the Reader admin bar item to the secondary group Aug 20, 2024

fushar reviewed Aug 21, 2024

View reviewed changes

allilevine force-pushed the update/admin-menu-reader-placement branch from 2ebfb24 to 439edd7 Compare August 21, 2024 17:28

github-actions bot added [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Aug 21, 2024

allilevine added 6 commits August 21, 2024 16:25

Move reader icon to the secondary admin bar group.

4be8a60

changelog

dcfc29f

Add mobile styling.

ccab5e6

Fix menu item order on Simple.

6bb223e

Fix the gap between Reader and Help Center.

488b60d

Rebase.

5bc75d1

allilevine force-pushed the update/admin-menu-reader-placement branch from 86c26fa to 5bc75d1 Compare August 21, 2024 20:27

Remove versioning.

96862a1

allilevine marked this pull request as ready for review August 21, 2024 20:59

allilevine requested a review from a team August 21, 2024 20:59

allilevine self-assigned this Aug 21, 2024

This was referenced Aug 21, 2024

Admin bar: Move reader menu item to right section Automattic/wp-calypso#93749

Merged

Reader - move admin bar link to the right side of the masterbar Automattic/wp-calypso#93534

Closed

Pixel perfect

1afe724

fushar previously approved these changes Aug 22, 2024

View reviewed changes

Addison-Stavlo reviewed Aug 22, 2024

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/features/help-center/class-help-center.php Show resolved Hide resolved

Addison-Stavlo reviewed Aug 22, 2024

View reviewed changes

Addison-Stavlo previously approved these changes Aug 22, 2024

View reviewed changes

Move padding to inner span.

03711e2

allilevine dismissed stale reviews from Addison-Stavlo and fushar via 03711e2 August 22, 2024 18:32

Merge remote-tracking branch 'origin/trunk' into update/admin-menu-re…

911ef33

…ader-placement

fushar force-pushed the update/admin-menu-reader-placement branch from 871ecbd to abc5bf9 Compare August 23, 2024 04:17

fushar previously approved these changes Aug 23, 2024

View reviewed changes

arthur791004 previously approved these changes Aug 23, 2024

View reviewed changes

Pixel perfect

58f828b

fushar dismissed stale reviews from arthur791004 and themself via 58f828b August 23, 2024 04:33

fushar force-pushed the update/admin-menu-reader-placement branch from abc5bf9 to 58f828b Compare August 23, 2024 04:33

fushar previously approved these changes Aug 23, 2024

View reviewed changes

Add code comments around the menu priorities.

73ea202

allilevine dismissed fushar’s stale review via 73ea202 August 23, 2024 13:22

Addison-Stavlo approved these changes Aug 23, 2024

View reviewed changes

allilevine merged commit 1a961a8 into trunk Aug 23, 2024
55 checks passed

allilevine deleted the update/admin-menu-reader-placement branch August 23, 2024 14:14

github-actions bot removed the [Status] In Progress label Aug 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Admin bar: move the Reader admin bar item to the secondary group #38976

Admin bar: move the Reader admin bar item to the secondary group #38976

allilevine commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

allilevine Aug 20, 2024

allilevine Aug 20, 2024

allilevine Aug 20, 2024

fushar left a comment

allilevine commented Aug 21, 2024

allilevine commented Aug 21, 2024

fushar left a comment

allilevine commented Aug 22, 2024

Addison-Stavlo left a comment

Addison-Stavlo left a comment

allilevine commented Aug 22, 2024

allilevine commented Aug 22, 2024

fushar left a comment •

edited

Loading

arthur791004 left a comment

@@ @@ -100,7 +100,8 @@ function ( $wp_admin_bar ) { @@
               							),
               						)
               					);
-              				}
+              				},
+

Admin bar: move the Reader admin bar item to the secondary group #38976

Admin bar: move the Reader admin bar item to the secondary group #38976

Conversation

allilevine commented Aug 20, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Aug 20, 2024 • edited Loading

github-actions bot commented Aug 20, 2024 • edited Loading

allilevine Aug 20, 2024

Choose a reason for hiding this comment

allilevine Aug 20, 2024

Choose a reason for hiding this comment

allilevine Aug 20, 2024

Choose a reason for hiding this comment

fushar left a comment

Choose a reason for hiding this comment

allilevine commented Aug 21, 2024

allilevine commented Aug 21, 2024

fushar left a comment

Choose a reason for hiding this comment

allilevine commented Aug 22, 2024

Addison-Stavlo left a comment

Choose a reason for hiding this comment

Addison-Stavlo left a comment

Choose a reason for hiding this comment

allilevine commented Aug 22, 2024

allilevine commented Aug 22, 2024

fushar left a comment • edited Loading

Choose a reason for hiding this comment

783px

600px

400px

350px

arthur791004 left a comment

Choose a reason for hiding this comment

allilevine commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024 •

edited

Loading

fushar left a comment •

edited

Loading