-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paid requests localization #38946
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
e9cbb3b
to
513bcb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes appear reasonable and work well on my self-hosted, simple, and atomic test sites:
Testing on Atomic was interesting. Currently, it's only possible to move a Dotcom site to the Atomic infra by purchasing a Business plan (which includes Jetpack Search classic), changing the host to wpcomstaging.com
(via plugin install or hosting config panel), and then manually removing the business upgrade from the site.
@@ -155,7 +156,7 @@ const OldPricingComponent = ( { sendToCart } ) => { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We appear to internationalize number formatting in two ways in this file:
- Using Intl.NumberFormat as shown in this PR.
- Using
__
as shown in line 313:__( '5k records', 'jetpack-search-pkg' )
.
We should simplify this and use a single internationalization approach in a future PR.
9836822
to
e0ceb06
Compare
…equests-localization
3773907
to
8aeb067
Compare
Fixes Automattic/i18n-issues#853
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/wp-admin/admin.php?page=jetpack-search
) and view the Features table.