Load Scheduled_Updates for non-wpcom users

[phcp]

Fixes https://github.com/Automattic/automattic-for-agencies-dev/issues/906

Proposed changes:

• This was introduced by this PR: Unify masterbars in Simple and Atomic Default sites (take 3) #38419
  • Moving the Scheduled_Updates initialization from load_features to load_wpcom_user_features made this module not be initialized when a site has the is_fully_managed_agency_site option (the is_wpcom_user function checks for this option).
• The Scheduled_Updates uses a hook to add an extra field is_managed for each plugin through add_is_managed_extension_field on projects/packages/scheduled-updates/src/class-scheduled-updates.php
  • So, if the module is missing for a site, this field won't be returned on /plugins request
• Moving just the Scheduled_Updates initialization back to the load_features fixes the issue

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Slack Thread: p1722965693473719-slack-C02TCEHP3HA

Does this pull request change what data or activity we track or use?

Testing instructions:

• Create two testing sites through A4A (one with the WPcom features enabled and the other disabled)
  • Meaning is_fully_managed_agency_site true for one site and false for the other
• Follow the instructions here to setup your sites
• Go to https://wordpress.com/plugins/scheduled-updates/create
• Select the managed site, and it should load only the non-managed plugins
• Select the unmanaged site, and similarly, it should load only the non-managed plugins
• Check if the /plugins request returns the is_managed value for each plugin in the response

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/load-scheduled-updates branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/load-scheduled-updates
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[phcp]

Tagging @Automattic/lego @fushar since you recently updated this code. I'd appreciate it if you could take a look at this PR.

[fushar]

Sorry I broke this... the changes look good to me 👍

[phcp]

No worries, @fushar. Thank you for your review!