-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/payments correct link to setup plans #38767
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There are "untangled" sites among WP.com sites which should also get redirected to JP cloud, but we can look into those separately. |
? 'https://cloud.jetpack.com/monetize/payments/' | ||
: 'https://wordpress.com/earn/payments/'; | ||
|
||
const link = base + location.hostname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a good opportunity to move away from location.hostname
, which won't return the correct information on sites that live in a subdirectory.
Could we rely on getRedirectUrl()
here maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a combo of getRedirectUrl()
and getSiteFragment()
would be best, and there are other places with /earn links where this is needed. Like Donations block.
d956d7e
to
e34bfa0
Compare
3e3338b
to
54342d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it contains more fixes, not only for the "Set up a paid plan" link.
Can you add some testing instructions to make it clear how to test it?
Resolves #38766
Links opening payment setup for Jetpack & WP.com sites now open to
wordpress.com/earn/
for everyone. This changes Jetpack sites to go for Jetpack Cloud version instead.Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: